This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
…al file and http remotes, plus json encoding/decoding Signed-off-by: David Chung <david.chung@docker.com>
Please sign your commits following these rules: $ git clone -b "templates" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353402680
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: David Chung <david.chung@docker.com>
Current coverage is 64.88% (diff: 50.24%)@@ master #353 diff @@
==========================================
Files 33 38 +5
Lines 1753 1942 +189
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1170 1260 +90
- Misses 467 548 +81
- Partials 116 134 +18
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to standardize on a common wrapper around the golang templates library. This is necessary to provide a common set of functions for all use cases of templating in this project. We expect to leverage templates more heavily to make the plugins more cusomizable without code change.
file:///abs/path/to/the/template
http://host:port/path/to/template
integration_test.go
for examples.text/template
; updated themain.go
in each to support specification of template URL with command-line flags.