Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Manager now uses a late binding proxy for group plugin #354

Merged
merged 3 commits into from Jan 9, 2017

Conversation

chungers
Copy link
Contributor

@chungers chungers commented Jan 6, 2017

Currently the manager functions as a stateful proxy for a stateless group plugin. It implements the group plugin SPI and intercepts user's api call to persist configs before dispatching the call out to the actual stateless group plugin for doing real work. As a result the current implementation expects a stateless group plugin to be running so that the manager can connect to it on startup.

This creates a problem of introducing ordering in how we start up the controllers. This PR fixes this by making a simple late-binding proxy for the group plugin. This way, plugin lookup / resolution doesn't take place on startup of the manager, but on the first call of the SPI methods.

This PR also sets the stage for implementing plugin activation by the manager, since the manager will be the first and only controller running and is responsible for starting up other plugins on-demand.

Signed-off-by: David Chung david.chung@docker.com

Signed-off-by: David Chung <david.chung@docker.com>
@codecov-io
Copy link

codecov-io commented Jan 6, 2017

Current coverage is 64.77% (diff: 50.74%)

Merging #354 into master will decrease coverage by 0.15%

@@             master       #354   diff @@
==========================================
  Files            38         39     +1   
  Lines          1942       1993    +51   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1261       1291    +30   
- Misses          547        569    +22   
+ Partials        134        133     -1   

Powered by Codecov. Last update a5967a1...2c7d2ab

David Chung added 2 commits January 8, 2017 16:37
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
@chungers chungers merged commit 8269243 into docker-archive:master Jan 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants