Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

End to end tests now includes the manager #355

Merged
merged 6 commits into from Jan 9, 2017

Conversation

chungers
Copy link
Contributor

@chungers chungers commented Jan 9, 2017

The tutorial and container tests in the scripts directory are good end-to-end tests that verify plugin-to-plugin communications/protocol and group controller's functionality. This PR adds the manager in the suite of plugins:

  • Note it is now the first to be started --- the manager no longer has a startup dependency on another group (stateless) plugin
  • The user's specification is now persisted on-disk (see the configs directory) thanks to the manager.
  • A file-based leader detection mechanism is used.

David Chung added 5 commits January 6, 2017 14:50
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "manager-tests2" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353495432
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: David Chung <david.chung@docker.com>
@codecov-io
Copy link

Current coverage is 64.77% (diff: 100%)

Merging #355 into master will not change coverage

@@             master       #355   diff @@
==========================================
  Files            39         39          
  Lines          1993       1993          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1291       1291          
  Misses          569        569          
  Partials        133        133          

Powered by Codecov. Last update 8269243...e94bdf0

@chungers chungers merged commit fd5894e into docker-archive:master Jan 9, 2017
@chungers chungers deleted the manager-tests2 branch January 9, 2017 01:25
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants