Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Plugin activation #356

Merged
merged 22 commits into from Jan 11, 2017
Merged

Plugin activation #356

merged 22 commits into from Jan 11, 2017

Conversation

chungers
Copy link
Contributor

This PR implements some of the features required in #284. Specifically

  • New packages pkg/launch and pkg/launch/os are added to implement launch a normal os binary via os exec, which is specified in a configuration json (the command and args required to start the process)
  • A new verb for infrakit plugin to start a list of named plugins.
  • A new config JSON that maps the plugin names to the 'how' in starting up the process
  • Added a new version of the tutorial_test to show case how to start the plugins in one CLI invocation.

TODO

  • Incorporate plugin activation in the manager so that manager will be able to launch plugins dynamically based on the config input.
  • Implement other executors -- such as plugins implemented as Docker containers or engine plugins.

David Chung added 19 commits November 9, 2016 12:06
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "284-activation" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353934280
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@chungers chungers changed the title 284 activation Plugin activation Jan 10, 2017
Signed-off-by: David Chung <david.chung@docker.com>
@codecov-io
Copy link

codecov-io commented Jan 10, 2017

Current coverage is 64.88% (diff: 65.54%)

Merging #356 into master will increase coverage by 0.15%

@@             master       #356   diff @@
==========================================
  Files            39         44     +5   
  Lines          1993       2110   +117   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1290       1369    +79   
- Misses          570        599    +29   
- Partials        133        142     +9   

Powered by Codecov. Last update fd5894e...3b50aed

David Chung added 2 commits January 10, 2017 22:06
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
@chungers chungers merged commit d13d069 into docker-archive:master Jan 11, 2017
@chungers chungers deleted the 284-activation branch January 11, 2017 06:13
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants