Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Clean shutdown of infrakit plugin start --wait #379

Merged

Conversation

chungers
Copy link
Contributor

@chungers chungers commented Feb 3, 2017

The utility infrakit plugin start in wait mode (--wait) will wait for the plugins it started to shutdown before terminating. This PR fixes a bug where it hangs even when all the plugins
have been stopped by another infrakit plugin stop --all.

David Chung added 3 commits February 1, 2017 19:43
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "0.3.0-proper-cleanup" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354379296
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@chungers chungers merged commit df07546 into docker-archive:release-0.3.0 Feb 3, 2017
@chungers chungers deleted the 0.3.0-proper-cleanup branch February 3, 2017 00:26
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants