Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Problem: Unable to create non-Docker Group plugin alternative. #394

Merged
merged 2 commits into from Feb 12, 2017

Conversation

tristanls
Copy link
Contributor

Solution: Remove RPC server reflector check for Docker-specific "github.com/docker/infrakit/pkg/rpc" string in package path.

Resolves #389

Solution: Remove RPC server reflector check for Docker-specific
          "github.com/docker/infrakit/pkg/rpc" string in package
          path.

Signed-off-by: Tristan Slominski <tristan.slominski@gmail.com>
@codecov-io
Copy link

codecov-io commented Feb 10, 2017

Codecov Report

Merging #394 into master will increase coverage by 0.04%.

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   62.53%   62.57%   +0.04%     
==========================================
  Files          56       56              
  Lines        3136     3129       -7     
==========================================
- Hits         1961     1958       -3     
+ Misses        946      944       -2     
+ Partials      229      227       -2
Impacted Files Coverage Δ
pkg/rpc/server/reflector.go 68.65% <ø> (+0.6%)
pkg/rpc/server/info.go 81.81% <ø> (+2.4%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913d307...ca560f1. Read the comment docs.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:tristanls/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354656528
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@chungers chungers merged commit f00e0d3 into docker-archive:master Feb 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants