This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Handle LogicalID for Softlayer instances #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current LogicalID processing in the terraform instance provider has two issues: - The LogicalID tag is only added to the tags if the tags object type is map but, for Softlayer, the tags object type is a list - Softlayer only supports lower-case chars in tags so all tag checks for "LogicalID" must support case-insensitive key checks This also moves the logic to make the Softlayer tags all lower case to one common place; allowing the code to process tags generically and then we manipulate at the end. Closes docker-archive#546 Signed-off-by: Steven Kaufer <kaufer@us.ibm.com>
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
+ Coverage 56.58% 56.87% +0.29%
==========================================
Files 57 57
Lines 3946 3954 +8
==========================================
+ Hits 2233 2249 +16
+ Misses 1426 1419 -7
+ Partials 287 286 -1
Continue to review full report at Codecov.
|
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Sep 30, 2017
Fixes docker-archive#548 Signed-off-by: David Gageot <david@gageot.net>
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Oct 1, 2017
Fixes docker-archive#548 Signed-off-by: David Gageot <david@gageot.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current LogicalID processing in the terraform instance provider has two issues:
The LogicalID tag is only added to the
tagsif thetagsobject type ismapbut, for Softlayer, the tags object type is alist; this causes the LogicalID to never be added as a tag. Then, when the group plugin issues aDescribeInstancesby group name, the instances returned have no LogicalID set -- and then the group plugin requests to create another instance.Softlayer only supports lower-case chars in tags so all tag checks for "LogicalID" must support case-insensitive key checks
This also moves the logic to make the Softlayer tags all lower case to one common place; allowing the code to process tags generically and then we manipulate at the end.
Closes #546
Signed-off-by: Steven Kaufer kaufer@us.ibm.com