This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 264
Provision full VPC on AWS using Resource Controller #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Please sign your commits following these rules: $ git clone -b "aws-resources" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354174864
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Codecov Report
@@ Coverage Diff @@
## master #890 +/- ##
==========================================
- Coverage 48.66% 48.46% -0.21%
==========================================
Files 85 84 -1
Lines 7790 7812 +22
==========================================
- Hits 3791 3786 -5
- Misses 3692 3718 +26
- Partials 307 308 +1
Continue to review full report at Codecov.
|
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
properties=true
bool flag when Describing instances to return properties of resources+ Adds a full
mystack.yml
that will create a full VPC with 1 internet gateway and 2 subnets+ Adds an
inventory.yml
for configuring the inventory controller which will monitor all the resources created by the resource controller (as driven bymystack.yml
) and make all the resource properties (e.g. VpcId) be available in metadata form.+ Updates the compute instance / spot instance playbook files to look at the metadata in suggesting default values such as availability zones and subnet ids.
See
examples/playbook/aws/README.md
for how to use.Signed-off-by: David Chung david.chung@docker.com