Clarify user ID for docker attach #39
Conversation
Signed-off-by: Misty Stanley-Jones <misty@docker.com>
|
@mstanleyjones should this be in the moby/moby or docker/cli repository first? |
|
Oh, and against the 17.06 release branch if it needs to go in there https://github.com/docker/docker-ce/tree/17.06 |
|
Thanks. I'm still not completely sure about talking about different users on the host - end users interact with Docker through a client, and the Docker daemon itself doesn't know or care which user account the client is running as, or even which host it's running on. But this is definitely better than the previous wording. LGTM. |
|
@andrewhsu should this get merged into the upstream repo instead? |
|
@thaJeztah is correct, we don't accept changes to components on the master branch, only in the release branches. If this is to be cherry-picked into the 17.06 release branch, it should first get merged in the upstream component. |
|
@aaronlehmann the thing I was trying to convey is that other users on the host can attach to a running container, even if they were not the ones that started that container. Thanks all, I'll re-open this in the right repo. cc/ @tibor as FYI because we were not sure about process. |
|
@mstanleyjones I don’t think you meant me, did you? |
|
No sorry, @tiborvass :/ It's not my day. |
Ubuntu kernel supports overlayfs in user namespaces. However, Docker had previously crafting overlay opaques directly using mknod(2) and setxattr(2), which are not supported in userns. Tested with LXD, Ubuntu 18.04, kernel 4.15.0-36-generic #39-Ubuntu. Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp> Upstream-commit: f8ed19c8b4dc17dc5b0147c12ce8c66d7c8898a6 Component: engine
Clarification was requested from @aaronlehmann while working on docker/docs#3494