This repository has been archived by the owner on Sep 12, 2018. It is now read-only.
- Added test_s3.py file which tests the S3Storage library using moto #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The methods stream_write and stream_read are not supported by moto yet * The s3_access_key and s3_secret_key must be lower case in order to perform the tests. - Removed the test/s3.py file - Added a little trick to the function get_size() from S3Storage() class
| @@ -225,4 +225,7 @@ def get_size(self, path): | |||
| key = self._s3_bucket.lookup(path) | |||
| if not key: | |||
| raise OSError('No such key: \'{0}\''.format(path)) | |||
| else: | |||
There was a problem hiding this comment.
This will change the s3 code for the whole app, not just the test. This cannot be merged.
What about monkey patching the method get_size from the test code?
There was a problem hiding this comment.
Ok. I got it! Good idea! :)
|
There are some efforts towards the stream_write and stream_read support from the moto contributors. Maybe we will be able to test it in a near future. |
- Added to the load() method from storage a custom config_data support - Added method check_env_variables() which checks if the environment variables exist in order to avoid error during the s3_storage tests - Created a patched version of get_size() method on test_s3.py file - Removed the patch from the S3Storage() class - Added the moto library to the requirements file - Added missing decorator above test_errors() method
|
Since moto does not allow testing stream functions, let's close this for now. @mzdaniel will submit a version not depending on moto. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the test/s3.py file
Created a patched version of get_size() method on test_s3.py file to work with moto
** The methods stream_write and stream_read are not supported by moto yet