This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[18.09 backport] builder: add workaround for gcr auth issue #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCR does not currently support 401 response from blob endpoints. This detects the case where no manifest requests have been performed for the current resolver and does a dummy request to enable authorization. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit bcd8298) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit cfce0ac) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
|
tonistiigi
changed the title
tiborvass
approved these changes
May 8, 2019
|
FWIW, made this "WIP" as there's some discussion about wether or not we should backport this hack, as it's (IIUC) something that should be fixed in the Google registries |
|
Experimental failure is a flaky; moby#38521 |
|
I'm fine either way. Would be great if Google could fix their registry. |
thaJeztah
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
back ports of moby#38246 and moby#39183 for 18.09
fixes moby#39182
addresses moby/buildkit#720 (comment)