This repository has been archived by the owner on Aug 20, 2021. It is now read-only.
remove possibleValues from controlImplementation[] #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove defaultValues from implementsProfiles Signed-off-by: aitchkhan <aitchkhan@gmail.com>
|
👍 LGTM over to @anweiss |
|
LGTM as well. |
asadullah-yousuf-10p
pushed a commit
to asadullah-yousuf-10p/oscalkit
that referenced
this pull request
Jan 16, 2019
remove defaultValues from implementsProfiles Signed-off-by: aitchkhan <aitchkhan@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controlImplementation[].paramters[]implementsProfiles[].parameters[]This change is made in favor of the oscal implementation "ComponentDefinition" as was suggested by @anweiss
As per the prototype, the chain
implementsProfiles[_].controlConfigurations[_].parameters[_]does not containdefaultValuesand the chaincontrolImplementations[_].controlConfigurations[_].parameters[_]does not containpossibleValues. Hence removed.