This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Windows: Update PATH for all users, not only the current one. #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Windows installer (optionally) updates the PATH environment variable for the user installing Docker-Toolbox.
In some environments, ordinary users don't have admin rights, but they still might have the option to use a dedicated 'local admin' account for installing additional software. When installing Docker-Toolbox in such an environment, the user's
PATH
environment variable is not updated; instead, the 'local admin' account receives the updatedPATH
. As a result, Docker Toolbox appears to be broken for the user when not being logged in as an administrator.The problem is mentioned in (at least) #598, #621, #260, #484 and also #469. This PR fixes them by having the installer updating the system-wide rather than the user specific
PATH
. As before, users can choose to not modify thePATH
at all.Another workaround (in
start.sh
) was proposed in #482, but the latter only works if that shell script is started (and VirtualBox launched / local VMs generated / ...). Users using their own shell separate from runningstart.sh
will continue to experience the problem.Another symptom is that Kitematic doesn't find the docker installation for an ordinary user (mentioned in, e.g., #598).
On the other hand, #483 suggests to remove updating the
PATH
entirely because it doesn't have benefits (i.e., it does not work?). However, as updating thePATH
is only an option, users can choose to keep thePATH
variable as-is if they desire so and know what they are doing.