Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional scrape from the CONFIG_DIRS #51

Open
Munchery-DavidMichon opened this issue May 24, 2018 · 3 comments
Open

add additional scrape from the CONFIG_DIRS #51

Munchery-DavidMichon opened this issue May 24, 2018 · 3 comments

Comments

@Munchery-DavidMichon
Copy link

I tried unsuccessfully to add additional scrape from the CONFIG_DIRS following this documentation

It seems that this method InsertScrapesFromDir is never called.
https://github.com/vfarcic/docker-flow-monitor/blob/0a4cc1de4d15f3fbd06fbfd99d9b4eecf824dcaa/prometheus/config.go#L142

@thomasjpfan
Copy link
Collaborator

@Munchery-DavidMichon Thanks for bringing this up. I am looking into it.

@thomasjpfan
Copy link
Collaborator

The CONFIGS_DIR feature is added in dockerflow/docker-flow-monitor:2-18.05.31-4.

@Munchery-DavidMichon
Copy link
Author

@thomasjpfan Thanks it fixes the issue and it's working properly. There's however an error appearing in the log, and this for every file_sd_configs.

level=error ts=2018-05-31T14:38:08.049286094Z caller=file.go:328
component="discovery manager scrape" discovery=file msg="Error reading file"
path=/etc/prometheus/file_sd/monitor_node-exporter.json err="unexpected end of JSON input"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants