DFP causes too many redirects on clients.

[alshabib]

Description

When using DFP to redirect http requests to https, the client accessing the url quits reporting too many redirects.

Steps to reproduce the issue:

1. Create proxy network
2. Create cert secret
3. Deploy proxy-stack.yml and go-demo.yml
4. curl -L https://test.mydomain.com/demo/hello (you may need to change domain)

Describe the results you received:

curl: (47) Maximum (50) redirects followed

Describe the results you expected:

Hello, World!

Additional information you deem important (e.g. issue happens only occasionally):

Previous versions of DFP did not have this problem (in particular, vfarcic/docker-flow-proxy:17.10.22-47).

Additional environment details (AWS, VirtualBox, physical, etc.):

DFP logs when the go-demo service is deployed. Here is a trace

Tried on AWS and Virtualbox environment.

[alshabib]

I think i figured out whats happening. The generated HAProxy config is incorrect (see snippet below):

acl url_demo_main8080_0 path_beg / acl domain_demo_main8080_0 hdr_beg(host) -i test.mydomain.com use_backend demo_main-be8080_0 if url_demo_main8080_0 domain_demo_main8080_0 acl is_demo_main_http hdr(X-Forwarded-Proto) http http-request redirect scheme https if is_demo_main_http url_demo_main8080_0 domain_demo_main8080_0 acl is_demo_main_https hdr(X-Forwarded-Proto) https http-request redirect scheme https if !is_demo_main_https url_demo_main8080_0 domain_demo_main8080_0

should be

acl url_demo_main8080_0 path_beg / acl domain_demo_main8080_0 hdr_beg(host) -i test.mydomain.com acl is_demo_main_http hdr(X-Forwarded-Proto) http http-request redirect scheme https if is_demo_main_http url_demo_main8080_0 domain_demo_main8080_0 use_backend demo_main-be8080_0 if url_demo_main8080_0 domain_demo_main8080_0

I'll try to submit a patch for this if I can figure out where it is happening.

[vfarcic]

The patch should probably be applied to https://github.com/docker-flow/docker-flow-proxy/blob/master/proxy/template.go . Please let me know if you'll give it a try with a PR.

[vfarcic]

It's available starting from dockerflow/docker-flow-proxy:18.04.16-36.

[alshabib]

Great thanks!

…

On Apr 16, 2018, 06:00 -0700, Viktor Farcic ***@***.***>, wrote: It's available starting from dockerflow/docker-flow-proxy:18.04.16-36. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.