Allow filtering by event type #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be failing in Netty https://travis-ci.com/github/docker-java/docker-java/jobs/320226609 |
|
@trajano please sync with the latest master |
bsideup
reviewed
May 23, 2020
docker-java-api/src/main/java/com/github/dockerjava/api/command/EventsCmd.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
May 24, 2020
docker-java-api/src/main/java/com/github/dockerjava/api/command/EventsCmd.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
May 24, 2020
docker-java-api/src/main/java/com/github/dockerjava/api/command/EventsCmd.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
May 24, 2020
docker-java-core/src/main/java/com/github/dockerjava/core/util/FiltersBuilder.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
May 24, 2020
docker-java-core/src/main/java/com/github/dockerjava/core/util/FiltersBuilder.java
Outdated
Show resolved
Hide resolved
…d/EventsCmd.java Co-authored-by: Sergei Egorov <bsideup@gmail.com>
…d/EventsCmd.java Co-authored-by: Sergei Egorov <bsideup@gmail.com>
…/FiltersBuilder.java Co-authored-by: Sergei Egorov <bsideup@gmail.com>
…/FiltersBuilder.java Co-authored-by: Sergei Egorov <bsideup@gmail.com>
|
@trajano sorry, it seems that I closed my tab with "please add tests" comment without sending it 😅 |
|
I think that's beyond my knowledge of the code base to do that. But feel free to take over from here. |
|
@trajano just have a look at |
bsideup
reviewed
Jun 3, 2020
docker-java/src/test/java/com/github/dockerjava/cmd/EventsCmdIT.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Jun 3, 2020
docker-java/src/test/java/com/github/dockerjava/cmd/EventsCmdIT.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Jun 3, 2020
docker-java/src/test/java/com/github/dockerjava/cmd/EventsCmdIT.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Jun 3, 2020
docker-java/src/test/java/com/github/dockerjava/cmd/EventsCmdIT.java
Outdated
Show resolved
Hide resolved
bsideup
approved these changes
Jun 4, 2020
|
@trajano looks good! Will merge once CI is green 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there's additional event types in the spec that were added in #1366 this allows filtering of the events being streamed.
This also adds the filter to the EventCmd