Introduce docker-java-transport module

docker-java-core/pom.xml

@@ -21,6 +21,11 @@
 			<artifactId>docker-java-api</artifactId>
 			<version>${project.version}</version>
 		</dependency>
+		<dependency>
+			<groupId>${project.groupId}</groupId>
+			<artifactId>docker-java-transport</artifactId>
+			<version>${project.version}</version>
+		</dependency>
 
 		<dependency>
 			<groupId>org.slf4j</groupId>
@@ -70,13 +75,6 @@
 			<version>3.0.1u2</version>
 			<scope>provided</scope>
 		</dependency>
-
-		<dependency>
-			<groupId>org.immutables</groupId>
-			<artifactId>value</artifactId>
-			<version>2.8.2</version>
-			<scope>provided</scope>
-		</dependency>
 	</dependencies>
 
 	<build>

docker-java-core/src/main/java/com/github/dockerjava/core/DefaultDockerCmdExecFactory.java

@@ -2,6 +2,7 @@
 
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import com.github.dockerjava.transport.DockerHttpClient;
 import com.google.common.collect.HashMultimap;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.MultimapBuilder;

docker-java-core/src/main/java/com/github/dockerjava/core/DefaultInvocationBuilder.java

@@ -14,6 +14,7 @@
 import com.github.dockerjava.api.exception.NotModifiedException;
 import com.github.dockerjava.api.exception.UnauthorizedException;
 import com.github.dockerjava.api.model.Frame;
+import com.github.dockerjava.transport.DockerHttpClient;
 import org.apache.commons.io.IOUtils;
 
 import java.io.ByteArrayInputStream;

docker-java-core/src/main/java/com/github/dockerjava/core/DockerClientImpl.java

@@ -148,6 +148,7 @@
 import com.github.dockerjava.core.command.UpdateSwarmNodeCmdImpl;
 import com.github.dockerjava.core.command.VersionCmdImpl;
 import com.github.dockerjava.core.command.WaitContainerCmdImpl;
+import com.github.dockerjava.transport.DockerHttpClient;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;

docker-java-core/src/main/java/com/github/dockerjava/core/FramedInputStreamConsumer.java

@@ -3,6 +3,7 @@
 import com.github.dockerjava.api.async.ResultCallback;
 import com.github.dockerjava.api.model.Frame;
 import com.github.dockerjava.api.model.StreamType;
+import com.github.dockerjava.transport.DockerHttpClient;
 
 import java.io.InputStream;
 import java.util.Arrays;

docker-java-core/src/main/java/com/github/dockerjava/core/SSLConfig.java

@@ -1,22 +1,10 @@
 package com.github.dockerjava.core;
 
-import java.security.KeyManagementException;
-import java.security.KeyStoreException;
-import java.security.NoSuchAlgorithmException;
-import java.security.UnrecoverableKeyException;
-
-import javax.net.ssl.SSLContext;
-
 /**
- * Get an SSL Config. Allows for various different implementations.
+ *
+ * @deprecated use {@link com.github.dockerjava.transport.SSLConfig}
  */
-public interface SSLConfig {
+@Deprecated
+public interface SSLConfig extends com.github.dockerjava.transport.SSLConfig {
 
-    /**
-     * Get the SSL Context, from wherever it comes (file, keystore).
-     *
-     * @return an SSL context.
-     */
-    SSLContext getSSLContext() throws KeyManagementException, UnrecoverableKeyException, NoSuchAlgorithmException,
-            KeyStoreException;
 }

docker-java-transport-httpclient5/pom.xml

@@ -18,7 +18,7 @@
 	<dependencies>
 		<dependency>
 			<groupId>${project.groupId}</groupId>
-			<artifactId>docker-java-core</artifactId>
+			<artifactId>docker-java-transport</artifactId>
 			<version>${project.version}</version>
 		</dependency>
 

docker-java-transport-httpclient5/src/main/java/com/github/dockerjava/httpclient5/ApacheDockerHttpClient.java

@@ -1,8 +1,7 @@
 package com.github.dockerjava.httpclient5;
 
-import com.github.dockerjava.core.DockerClientConfig;
-import com.github.dockerjava.core.DockerHttpClient;
-import com.github.dockerjava.core.SSLConfig;
+import com.github.dockerjava.transport.SSLConfig;
+import com.github.dockerjava.transport.DockerHttpClient;
 import org.apache.hc.client5.http.classic.methods.HttpUriRequestBase;
 import org.apache.hc.client5.http.impl.classic.CloseableHttpClient;
 import org.apache.hc.client5.http.impl.classic.CloseableHttpResponse;
@@ -44,27 +43,35 @@ public final class ApacheDockerHttpClient implements DockerHttpClient {
 
     public static final class Factory {
 
-        private DockerClientConfig dockerClientConfig = null;
+        private URI dockerHost = null;
 
-        public Factory dockerClientConfig(DockerClientConfig value) {
-            this.dockerClientConfig = value;
+        private SSLConfig sslConfig = null;
+
+        public Factory dockerHost(URI value) {
+            this.dockerHost = Objects.requireNonNull(value, "dockerHost");
+            return this;
+        }
+
+        public Factory sslConfig(SSLConfig value) {
+            this.sslConfig = value;
             return this;
         }
 
         public ApacheDockerHttpClient build() {
-            Objects.requireNonNull(dockerClientConfig, "dockerClientConfig");
-            return new ApacheDockerHttpClient(dockerClientConfig);
+            Objects.requireNonNull(dockerHost, "dockerHost");
+            return new ApacheDockerHttpClient(dockerHost, sslConfig);
         }
     }
 
     private final CloseableHttpClient httpClient;
 
     private final HttpHost host;
 
-    private ApacheDockerHttpClient(DockerClientConfig dockerClientConfig) {
-        Registry<ConnectionSocketFactory> socketFactoryRegistry = createConnectionSocketFactoryRegistry(dockerClientConfig);
-
-        URI dockerHost = dockerClientConfig.getDockerHost();
+    private ApacheDockerHttpClient(
+        URI dockerHost,
+        SSLConfig sslConfig
+    ) {
+        Registry<ConnectionSocketFactory> socketFactoryRegistry = createConnectionSocketFactoryRegistry(sslConfig, dockerHost);
 
         switch (dockerHost.getScheme()) {
             case "unix":
@@ -106,10 +113,12 @@ private ApacheDockerHttpClient(DockerClientConfig dockerClientConfig) {
             .build();
     }
 
-    private Registry<ConnectionSocketFactory> createConnectionSocketFactoryRegistry(DockerClientConfig dockerClientConfig) {
+    private Registry<ConnectionSocketFactory> createConnectionSocketFactoryRegistry(
+        SSLConfig sslConfig,
+        URI dockerHost
+    ) {
         RegistryBuilder<ConnectionSocketFactory> socketFactoryRegistryBuilder = RegistryBuilder.create();
 
-        SSLConfig sslConfig = dockerClientConfig.getSSLConfig();
         if (sslConfig != null) {
             try {
                 SSLContext sslContext = sslConfig.getSSLContext();
@@ -127,16 +136,12 @@ private Registry<ConnectionSocketFactory> createConnectionSocketFactoryRegistry(
             .register("unix", new PlainConnectionSocketFactory() {
                 @Override
                 public Socket createSocket(HttpContext context) throws IOException {
-                    URI dockerHost = dockerClientConfig.getDockerHost();
-
                     return new UnixDomainSocket(dockerHost.getPath());
                 }
             })
             .register("npipe", new PlainConnectionSocketFactory() {
                 @Override
                 public Socket createSocket(HttpContext context) {
-                    URI dockerHost = dockerClientConfig.getDockerHost();
-
                     return new NamedPipeSocket(dockerHost.getPath());
                 }
             })

docker-java-transport-jersey/src/main/java/com/github/dockerjava/jaxrs/JerseyDockerCmdExecFactory.java

@@ -6,7 +6,7 @@
 import com.github.dockerjava.core.DockerClientConfig;
 import com.github.dockerjava.core.DockerClientConfigAware;
 import com.github.dockerjava.core.DockerClientImpl;
-import com.github.dockerjava.core.DockerHttpClient;
+import com.github.dockerjava.transport.DockerHttpClient;
 import org.glassfish.jersey.client.RequestEntityProcessing;
 
 import javax.ws.rs.client.ClientRequestFilter;
@@ -37,7 +37,9 @@ public final DockerCmdExecFactory getDockerCmdExecFactory() {
 
     @Override
     public void init(DockerClientConfig dockerClientConfig) {
-        clientFactory = clientFactory.dockerClientConfig(dockerClientConfig);
+        clientFactory = clientFactory
+            .dockerHost(dockerClientConfig.getDockerHost())
+            .sslConfig(dockerClientConfig.getSSLConfig());
         dockerCmdExecFactory = new DefaultDockerCmdExecFactory(
             clientFactory.build(),
             dockerClientConfig.getObjectMapper()

docker-java-transport-jersey/src/main/java/com/github/dockerjava/jaxrs/JerseyDockerHttpClient.java

@@ -1,11 +1,9 @@
 package com.github.dockerjava.jaxrs;
 
-import com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider;
 import com.github.dockerjava.api.exception.DockerClientException;
 import com.github.dockerjava.api.exception.DockerException;
-import com.github.dockerjava.core.DockerClientConfig;
-import com.github.dockerjava.core.DockerHttpClient;
-import com.github.dockerjava.core.SSLConfig;
+import com.github.dockerjava.transport.DockerHttpClient;
+import com.github.dockerjava.transport.SSLConfig;
 import com.github.dockerjava.jaxrs.filter.ResponseStatusExceptionFilter;
 import com.github.dockerjava.jaxrs.filter.SelectiveLoggingFilter;
 import org.apache.http.client.config.RequestConfig;
@@ -42,12 +40,15 @@
 import java.net.URISyntaxException;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 
 public final class JerseyDockerHttpClient implements DockerHttpClient {
 
     public static final class Factory {
 
-        private DockerClientConfig dockerClientConfig = null;
+        private URI dockerHost = null;
+
+        private SSLConfig sslConfig = null;
 
         private Integer readTimeout = null;
 
@@ -65,8 +66,13 @@ public static final class Factory {
 
         private RequestEntityProcessing requestEntityProcessing;
 
-        public Factory dockerClientConfig(DockerClientConfig value) {
-            this.dockerClientConfig = value;
+        public Factory dockerHost(URI value) {
+            this.dockerHost = Objects.requireNonNull(value, "dockerHost");
+            return this;
+        }
+
+        public Factory sslConfig(SSLConfig value) {
+            this.sslConfig = value;
             return this;
         }
 
@@ -112,7 +118,8 @@ public Factory requestEntityProcessing(RequestEntityProcessing value) {
 
         public JerseyDockerHttpClient build() {
             return new JerseyDockerHttpClient(
-                dockerClientConfig,
+                dockerHost,
+                sslConfig,
                 maxTotalConnections,
                 maxPerRouteConnections,
                 connectionRequestTimeout,
@@ -134,7 +141,8 @@ public JerseyDockerHttpClient build() {
     private final URI originalUri;
 
     private JerseyDockerHttpClient(
-        DockerClientConfig dockerClientConfig,
+        URI dockerHost,
+        SSLConfig sslConfig,
         Integer maxTotalConnections,
         Integer maxPerRouteConnections,
         Integer connectionRequestTimeout,
@@ -152,12 +160,10 @@ private JerseyDockerHttpClient(
             clientConfig.property(ClientProperties.REQUEST_ENTITY_PROCESSING, requestEntityProcessing);
         }
 
-        clientConfig.register(new ResponseStatusExceptionFilter(dockerClientConfig.getObjectMapper()));
+        clientConfig.register(new ResponseStatusExceptionFilter());
         // clientConfig.register(JsonClientFilter.class);
         RequestConfig.Builder requestConfigBuilder = RequestConfig.custom();
 
-        clientConfig.register(new JacksonJsonProvider(dockerClientConfig.getObjectMapper()));
-
         // logging may disabled via log level
         clientConfig.register(new SelectiveLoggingFilter(LOGGER, true));
 
@@ -187,12 +193,9 @@ private JerseyDockerHttpClient(
             }
         }
 
-        URI dockerHost = dockerClientConfig.getDockerHost();
-
         SSLContext sslContext = null;
 
         try {
-            final SSLConfig sslConfig = dockerClientConfig.getSSLConfig();
             if (sslConfig != null) {
                 sslContext = sslConfig.getSSLContext();
             }

docker-java-transport-jersey/src/main/java/com/github/dockerjava/jaxrs/filter/ResponseStatusExceptionFilter.java

@@ -1,22 +1,7 @@
 package com.github.dockerjava.jaxrs.filter;
 
-import java.io.IOException;
-import java.io.InputStream;
-import java.nio.charset.Charset;
-
-import javax.ws.rs.client.ClientRequestContext;
-import javax.ws.rs.client.ClientResponseContext;
-import javax.ws.rs.client.ClientResponseFilter;
-import javax.ws.rs.core.MediaType;
-
-import com.github.dockerjava.core.DefaultDockerClientConfig;
-import org.apache.commons.io.IOUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
-
 import com.github.dockerjava.api.exception.BadRequestException;
 import com.github.dockerjava.api.exception.ConflictException;
 import com.github.dockerjava.api.exception.DockerException;
@@ -25,6 +10,17 @@
 import com.github.dockerjava.api.exception.NotFoundException;
 import com.github.dockerjava.api.exception.NotModifiedException;
 import com.github.dockerjava.api.exception.UnauthorizedException;
+import org.apache.commons.io.IOUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.ws.rs.client.ClientRequestContext;
+import javax.ws.rs.client.ClientResponseContext;
+import javax.ws.rs.client.ClientResponseFilter;
+import javax.ws.rs.core.MediaType;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.Charset;
 
 /**
  * This {@link ClientResponseFilter} implementation detects http status codes and throws {@link DockerException}s
@@ -41,7 +37,7 @@ public class ResponseStatusExceptionFilter implements ClientResponseFilter {
 
     @Deprecated
     public ResponseStatusExceptionFilter() {
-        this(DefaultDockerClientConfig.createDefaultConfigBuilder().build().getObjectMapper());
+        this(new ObjectMapper());
     }
 
     public ResponseStatusExceptionFilter(ObjectMapper objectMapper) {

docker-java-transport-okhttp/src/main/java/com/github/dockerjava/okhttp/HijackingInterceptor.java

@@ -1,6 +1,6 @@
 package com.github.dockerjava.okhttp;
 
-import com.github.dockerjava.core.DockerHttpClient;
+import com.github.dockerjava.transport.DockerHttpClient;
 import okhttp3.Interceptor;
 import okhttp3.Request;
 import okhttp3.Response;