Add Name to ContainerNetworkConfig
#2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harald Albers <github@albersweb.de>
eddumelendez
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
First appearance was on v1.22 https://docs.docker.com/engine/api/v1.22/
docker-java-api/src/main/java/com/github/dockerjava/api/model/Network.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>
|
Thanks for your contribution, @albers! This is now merged in |
|
Thank you @eddumelendez. I'm looking forward to the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where this property would be very helpful:
In a Quarkus integration test, I have to find a container in a temporary network based on its name.
With the current codebase, I have to inspect each container in the network in order to find the matching container.
Having the container name available in
ContainerNetworkConfigwould simplify the search.The
Nameproperty appears first in the v1.30 Docker api docs.