Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: convincing generate.sh to do a buildkit build #98

Closed
grooverdan opened this issue Jun 7, 2024 · 2 comments
Closed

question: convincing generate.sh to do a buildkit build #98

grooverdan opened this issue Jun 7, 2024 · 2 comments

Comments

@grooverdan
Copy link

I'm trying to work out how to make generate.sh output a buildkit build on this criteria. Where is .builder = "buildkit" set?

elif .builder == "buildkit" then

This is so I can access the COPY --chmod synax (ref) and can avoid another layer like:

https://github.com/MariaDB/mariadb-docker/pull/593/files#diff-06aaf016508acc42e173e462fdda2de06e46f80227174d6bcaf20019657a5efeR31-R33
@grooverdan grooverdan changed the title question: convincing generate.sh to do a buildbik build question: convincing generate.sh to do a buildkit build Jun 7, 2024
@yosifkit
Copy link
Member

yosifkit commented Jun 7, 2024

Adding Builder: buildkit to the output of your generate-stackbrew-library.sh should do the trick. (i.e. eventually to the library/mariadb file in appropriate sections as needed)

Like golang: https://github.com/docker-library/golang/blob/58bc678a838d467ca5afb7e0ee636cf5b8459da2/generate-stackbrew-library.sh#L68

(note, that if you have them, it won't work for Windows builds since buildkit is not yet supported there, so you'll want those to stay on classic)

@grooverdan
Copy link
Author

thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants