Merge github.com/docker-library/go-dockerlibrary into bashbrew #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wing "first" and "last" to work on arbitrary types instead of just strings
Allow to specify custom name for Dockerfile
Add Windows to Travis matrix
This copies the exact `mainfest.Global.Maintainers` validation from `rfc2822.go`.
…ers-equally Force line-based files to have valid "Maintainers" too
…(instead of only doing so just before "git archive" inside bashbrew)
Add "(Shared)Tags" validation
Fix codecov on Windows workers by avoiding <()
See https://golang.org/doc/go1.12#text/template, especially: > If a user-defined function called by a template panics, the panic is now caught and returned as an error by the `Execute` or `ExecuteTemplate` method.
Update Travis Go versions to 1.12 and 1.13
Looking at https://golang.org/doc/install/source#environment under "GOARCH", this is the accepted Go architecture value for the 64-bit little endian MIPS platform.
Add "mips64le" in SupportedArches
Update README to point to bashbrew tool repo
…turning line-based parsing errors
As a first step towards line-based manifest file deprecation, stop returning line-based parsing errors
This adjusts import paths, go.mod, and adds a new "Dockerfile.test" to run the unit tests.
yosifkit
approved these changes
Aug 20, 2020
tianon
added a commit
to docker-library/go-dockerlibrary
that referenced
this pull request
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts import paths, go.mod, and adds a new "Dockerfile.test" to run the unit tests.
(and imports the full commit history)
The intent is to now deprecate the https://github.com/docker-library/go-dockerlibrary repository, since this repository is the primary consumer of that library (and it doesn't make sense to maintain friction for ourselves in updating it).