Skip to content

Commit

Permalink
Restrict channel aliases to 19.03
Browse files Browse the repository at this point in the history
This will remove the "test" and "stable" aliases for whatever major release comes after 19.03 (so once the next release comes out, "stable" will become a stale alias).

I'm not 100% sure this is the right answer, but the "stable" alias has definitely been a huge source of confusion very recently (and it doesn't have much meaning anymore anyways given the death of the "edge" channel).
  • Loading branch information
tianon committed Aug 2, 2019
1 parent 34acb09 commit 606c639
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions generate-stackbrew-library.sh
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,12 @@ for version in "${versions[@]}"; do
${aliases[$version]:-}
)
if [ -z "${latestChannelRelease[$channel]:-}" ]; then
versionAliases+=( "$channel" )
if [ "$rcVersion" = '19.03' ]; then versionAliases+=( "$channel" ); fi # 19.03 is the last release to include any "channel" aliases
latestChannelRelease[$channel]="$version"
fi
# every release goes into the "test" channel, so the biggest numbered release wins (RC or not)
if [ -z "${latestChannelRelease['test']:-}" ]; then
versionAliases+=( 'test' )
if [ "$rcVersion" = '19.03' ]; then versionAliases+=( 'test' ); fi # 19.03 is the last release to include any "channel" aliases
latestChannelRelease['test']="$version"
fi
if [ "$version" = "$rcVersion" ] && [ -z "${latestChannelRelease['latest']:-}" ]; then
Expand Down

0 comments on commit 606c639

Please sign in to comment.