Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SharedTags information to "Supported tags" listing #1003

Merged
merged 1 commit into from
Sep 13, 2017

Conversation

tianon
Copy link
Member

@tianon tianon commented Sep 13, 2017

This is based on what we spitballed over in docker-library/go-dockerlibrary#2 (comment) and created an actual bashbrew cat format for in docker-library/official-images#2289 (comment). 👍

@tianon
Copy link
Member Author

tianon commented Sep 13, 2017

Here's an example of how this changes hello-world's description:

Supported tags and respective Dockerfile links

Shared Tags

Simple Tags

Quick reference

...

@tianon
Copy link
Member Author

tianon commented Sep 13, 2017

Applying the following diff to library/golang:

diff --git a/library/golang b/library/golang
index 1c07da3..3d1d006 100644
--- a/library/golang
+++ b/library/golang
@@ -5,7 +5,8 @@ Maintainers: Tianon Gravi <admwiggin@gmail.com> (@tianon),
              Johan Euphrosine <proppy@google.com> (@proppy)
 GitRepo: https://github.com/docker-library/golang.git
 
-Tags: 1.9.0-stretch, 1.9-stretch, 1-stretch, stretch, 1.9.0, 1.9, 1, latest
+Tags: 1.9.0-stretch, 1.9-stretch, 1-stretch, stretch
+SharedTags: 1.9.0, 1.9, 1, latest
 Architectures: amd64, arm32v7, arm64v8, i386, ppc64le, s390x
 GitCommit: 94e49ca93c5bbf172e462cea8872c77f9bc08c10
 Directory: 1.9/stretch
@@ -16,6 +17,7 @@ GitCommit: 94e49ca93c5bbf172e462cea8872c77f9bc08c10
 Directory: 1.9/alpine3.6
 
 Tags: 1.9.0-windowsservercore, 1.9-windowsservercore, 1-windowsservercore, windowsservercore
+SharedTags: 1.9.0, 1.9, 1, latest
 Architectures: windows-amd64
 GitCommit: f34c645c8402bd8f6b70f530545ad7845dfefbcc
 Directory: 1.9/windows/windowsservercore
@@ -32,7 +34,8 @@ Architectures: amd64, arm32v7, i386, ppc64le, s390x
 GitCommit: 94e49ca93c5bbf172e462cea8872c77f9bc08c10
 Directory: 1.8/stretch
 
-Tags: 1.8.3-jessie, 1.8-jessie, 1.8.3, 1.8
+Tags: 1.8.3-jessie, 1.8-jessie
+SharedTags: 1.8.3, 1.8
 Architectures: amd64, arm32v7, i386, ppc64le, s390x
 GitCommit: 94e49ca93c5bbf172e462cea8872c77f9bc08c10
 Directory: 1.8/jessie
@@ -53,6 +56,7 @@ GitCommit: 132cd70768e3bc269902e4c7b579203f66dc9f64
 Directory: 1.8/onbuild
 
 Tags: 1.8.3-windowsservercore, 1.8-windowsservercore
+SharedTags: 1.8.3, 1.8
 Architectures: windows-amd64
 GitCommit: 64b88dc3e9d83e71eafc000fed1f0d5e289b3e65
 Directory: 1.8/windows/windowsservercore

Creates the following header:

Supported tags and respective Dockerfile links

Shared Tags

Simple Tags

Quick reference

...

@tianon
Copy link
Member Author

tianon commented Sep 13, 2017

The header for amd64/hello-world will look like this:

Supported tags and respective Dockerfile links

Shared Tags

Simple Tags

Quick reference

...

@tianon
Copy link
Member Author

tianon commented Sep 13, 2017

And the header for winamd64/hello-world:

Supported tags and respective Dockerfile links

Shared Tags

Simple Tags

Quick reference

...

@tianon
Copy link
Member Author

tianon commented Sep 13, 2017

(All other headers for images with no SharedTags remain identical.)

@yosifkit yosifkit merged commit a4dbe9a into docker-library:master Sep 13, 2017
@yosifkit yosifkit deleted the SharedTags branch September 13, 2017 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants