Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add a note about TLS #1525

Merged
merged 1 commit into from Jul 17, 2019
Merged

Conversation

AkihiroSuda
Copy link
Contributor

TCP connection without TLS is completely insecure and can easily result
in container breakout.

Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp

@AkihiroSuda
Copy link
Contributor Author

@tianon @justincormack @thaJeztah PTAL

@justincormack
Copy link

I think we should remove this default from the dind containers.

@tianon
Copy link
Member

tianon commented Jul 9, 2019

@justincormack if we remove the default, the container will default to unix-socket only, which makes for a pretty irritating user experience from a container 😞 Any ideas for how to resolve that?

@AkihiroSuda
Copy link
Contributor Author

@tianon

Any ideas for how to resolve that?

My suggestion is to let dind create TLS files on start up
docker-library/docker#164

$ docker run -d --privileged --name some-docker \
  -e DIND_TLS_SAN=DNS:docker,DNS:localhost docker:dind
$ docker cp some-docker:/certs/for-client ./certs-for-client
$ docker run --rm --link some-docker:docker -v $(pwd)/certs-for-client:/root/.docker \
  -e DOCKER_HOST=tcp://docker:2376 docker info

@AkihiroSuda
Copy link
Contributor Author

Can we get this merged?

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title docker: remove insecure tcp://0.0.0.0:2375 configuration docker: add a note about TLS Jul 17, 2019
@tianon tianon merged commit b5de768 into docker-library:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants