emphasis on recommended solutions #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcohol
force-pushed
the
master
branch
2 times, most recently
from
060e029
to
5e4d110
Compare
derrabus
suggested changes
Jul 10, 2019
exussum12
reviewed
Jul 10, 2019
There was a problem hiding this comment.
Would the multi stage build not also be recommended for the PHP version ? Not just the extensions ?
May be personal preference but I hardly ever put the platform in especially for docker builds as it's much easier to update
Looks much better though ! Thanks for the quick pr!
exussum12
approved these changes
Jul 10, 2019
|
Looks perfect. Great work! |
derrabus
approved these changes
Jul 10, 2019
alcohol
force-pushed
the
master
branch
2 times, most recently
from
7c9cd45
to
0ef1b34
Compare
exussum12
approved these changes
Jul 10, 2019
tianon
reviewed
Jul 10, 2019
yosifkit
approved these changes
Jul 12, 2019
tianon
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.