Add "description cut off" warning at end too #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has to be slightly more clever than the warning at the beginning to try and avoid weird markdown rendering (so it looks reasonably clean) but it isn't *too* horrible.
This was referenced Apr 7, 2022
|
https://hub.docker.com/r/tianon/test (currently) shows what this looks like:
|
|
I hand-checked the markdown of the other few that are currently over the limit and they all appeared to be pretty reasonable. 👍 Reference:$ wc -c */README.md | sort -n | tail -n11
24738 nats-streaming/README.md
26858 mariadb/README.md
27981 mongo/README.md
28408 postgres/README.md
28537 php/README.md
30901 nextcloud/README.md
31379 eclipse-temurin/README.md
35875 openjdk/README.md
36940 tomcat/README.md
37533 influxdb/README.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has to be slightly more clever than the warning at the beginning to try and avoid weird markdown rendering (so it looks reasonably clean) but it isn't too horrible.
Fixes docker/hub-feedback#2220