Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for alpine 3.17, remove alpine 3.15 #442

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

squizzi
Copy link
Contributor

@squizzi squizzi commented Nov 21, 2022

This PR adds support for alpine 3.17 and removes support for 3.15 to adhere to the policy of only supporting two major releases.

@squizzi
Copy link
Contributor Author

squizzi commented Nov 21, 2022

Apparently alpine:3.17 is still in RC stages so I jumped the gun a bit on this, but it should be out officially by end of week.

Edit: Andddd now it's released

@tianon
Copy link
Member

tianon commented Nov 28, 2022

Nice, thanks! 👍

We should also ditch this entire RUN line (and associated comments) now that we don't need to deal with 3.15 anymore: 👀

# ensure that nsswitch.conf is set up for Go's "netgo" implementation
# - https://github.com/golang/go/blob/go1.19.3/src/net/conf.go#L227-L303
# - docker run --rm debian grep '^hosts:' /etc/nsswitch.conf
# Alpine 3.16 includes nsswitch.conf
RUN set -eux; \
if [ -e /etc/nsswitch.conf ]; then \
grep '^hosts: files dns' /etc/nsswitch.conf; \
else \
echo 'hosts: files dns' > /etc/nsswitch.conf; \
fi

(I'm happy to take over and make this change if you would rather not do so!)

@squizzi
Copy link
Contributor Author

squizzi commented Nov 29, 2022

We should also ditch this entire RUN line (and associated comments) now that we don't need to deal with 3.15 anymore: eyes

@tianon How's that look?

Dockerfile-linux.template Outdated Show resolved Hide resolved
* Remove nsswitch.conf setup since alpine 3.16 and above contain
  nsswitch.conf by default.

Signed-off-by: Kyle Squizzato <ksquizzato@mirantis.com>
@tianon tianon merged commit c5ab9e5 into docker-library:master Nov 30, 2022
@tianon
Copy link
Member

tianon commented Nov 30, 2022

Nice thank you! (and thanks for sticking with it!)

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 1, 2022
Changes:

- docker-library/golang@c5ab9e5: Merge pull request docker-library/golang#442 from squizzi/add_alpine_317
- docker-library/golang@d66a926: Add support for alpine 3.17, remove alpine 3.15
- docker-library/golang@326acd5: Use new "bashbrew" composite action
@squizzi squizzi deleted the add_alpine_317 branch December 6, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants