add -fno-PIC when using external linker on alpine #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| && apk del .build-deps | ||
|
|
||
|
|
There was a problem hiding this comment.
Can you move this extra blank line up between ENV and COPY on lines 9 and 10? 🙏 (and please add a comment referencing https://golang.org/issue/14851 while you're at it 👍)
ie:
ENV GOLANG_....
# https://golang.org/issue/14851
COPY no-pic.patch /
RUN ...The Alpine toolchain enables PIE by default. Since the go linker does not (yet) support PIE we need to explicitly disable it on Alpine. This is a workaround for golang/go#14851
ncopa
force-pushed
the
golang-alpine-pie-fix
branch
from
16dd63a
to
0f3ab4a
Compare
|
good suggestions 👍 pushed updated fix. thanks! |
|
I want a reminder of where we need to look for whether we can take this back out yet. 😇 👍 Thanks for updating! LGTM |
|
LGTM |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Apr 4, 2016
- `django`: 1.9.5 - `docker`: 1.11.0-rc3, add tune2fs and mkfs.xfs (docker-library/docker#10) - `elasticsearch`: 2.3.1 - `golang`: force-enable `-fno-PIC` in Alpine (docker-library/golang#91) - `irssi`: 0.8.19 (jessfraz/irssi#6), add Alpine variant (jessfraz/irssi#7) - `java`: 9~b112-2 (still fails to build), Alpine to 8.77.03-r0 (8u77), fix Alpine tags to reference the proper version - `julia`: 0.4.5 - `mariadb`: 10.1.13+maria-1~jessie - `mongo`: 3.0.11 - `mysql`: `ENTRYPOINT` consistency (`docker-entrypoint.sh` with a compatibility symlink) - `owncloud`: add `exif` module (docker-library/owncloud#53) - `php`: 7.0.5, 5.6.20, 5.5.34, always enable `mbstring` (docker-library/php#211) - `postgres`: 9.5.2-1.pgdg80+1, 9.4.7-1.pgdg80+1, 9.3.12-1.pgdg80+1, 9.2.16-1.pgdg80+1, 9.1.21-1.pgdg80+1, local interfaces during init (docker-library/postgres#136) - `pypy`: 5.0.1 - `python`: fix `python-config` symlink (docker-library/python#99) - `rocket.chat`: 0.24.0 - `ruby`: 2.1.9, switch `libedit` to `readline` for `irb` (docker-library/ruby#76)
dochang
added a commit
to dochang/docker-alpine-scripts
that referenced
this pull request
Jun 3, 2016
See docker-library/golang#91 for details.
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `django`: 1.9.5 - `docker`: 1.11.0-rc3, add tune2fs and mkfs.xfs (docker-library/docker#10) - `elasticsearch`: 2.3.1 - `golang`: force-enable `-fno-PIC` in Alpine (docker-library/golang#91) - `irssi`: 0.8.19 (jessfraz/irssi#6), add Alpine variant (jessfraz/irssi#7) - `java`: 9~b112-2 (still fails to build), Alpine to 8.77.03-r0 (8u77), fix Alpine tags to reference the proper version - `julia`: 0.4.5 - `mariadb`: 10.1.13+maria-1~jessie - `mongo`: 3.0.11 - `mysql`: `ENTRYPOINT` consistency (`docker-entrypoint.sh` with a compatibility symlink) - `owncloud`: add `exif` module (docker-library/owncloud#53) - `php`: 7.0.5, 5.6.20, 5.5.34, always enable `mbstring` (docker-library/php#211) - `postgres`: 9.5.2-1.pgdg80+1, 9.4.7-1.pgdg80+1, 9.3.12-1.pgdg80+1, 9.2.16-1.pgdg80+1, 9.1.21-1.pgdg80+1, local interfaces during init (docker-library/postgres#136) - `pypy`: 5.0.1 - `python`: fix `python-config` symlink (docker-library/python#99) - `rocket.chat`: 0.24.0 - `ruby`: 2.1.9, switch `libedit` to `readline` for `irb` (docker-library/ruby#76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Alpine toolchain enables PIE by default. Since the go linker does
not (yet) support PIE we need to explicitly disable it on Alpine.
This is a workaround for golang/go#14851