Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to give elasticsearch username and password #45

Closed
wants to merge 1 commit into from

Conversation

myoung34
Copy link

  • Also set executable bit to docker-entrypoint.sh. This bit is lost on
  • clone and causes some headache if you dont set it manually (locally).

 * Also set executable bit to docker-entrypoint.sh. This bit is lost on
 * clone and causes some headache if you dont set it manually (locally).
@tianon
Copy link
Member

tianon commented May 11, 2016

Regarding setting username and password, I'm a little bit on the fence. This image is intended to be as vanilla as possible, and part of that vanilla experience is setting up your own configuration. The main reason we support ELASTICSEARCH_URL was to allow Docker linking to work reasonably, which is an irritating experience otherwise.

Regarding issues with the script being executable, I can't reproduce:

$ git clone https://github.com/docker-library/kibana.git
Cloning into 'kibana'...
remote: Counting objects: 238, done.
remote: Total 238 (delta 0), reused 0 (delta 0), pack-reused 238
Receiving objects: 100% (238/238), 47.45 KiB | 0 bytes/s, done.
Resolving deltas: 100% (97/97), done.
Checking connectivity... done.
$ ls -l kibana/4.5/docker-entrypoint.sh
-rwxrwxr-x 1 tianon tianon 372 May 11 13:12 kibana/4.5/docker-entrypoint.sh

@myoung34
Copy link
Author

myoung34 commented May 11, 2016

It's vanilla if you consider the fact that its directly supported in the kibana.yml There are no other modifications to running or built artifacts

As for the executable bit, it's absolutely required for it to work properly, so it's a safe RUN command even if it did not toggle it.

Oh and it happened from doing a wget on the raw file from github (long story), so it was user error, but it's still a safe operation. I can remove it if need-be.

@myoung34
Copy link
Author

myoung34 commented May 11, 2016

I just really don't want to have to maintain my own fork of the kibana container (in ECS) because I need to make changes to the config file. If i was adding/removing/modifying functionality I'd agree, but I'm only providing the ability to modify lines that already exist in the vanilla config file with no changes to anything else whatsoever.

@myoung34
Copy link
Author

myoung34 commented Oct 5, 2016

@tianon any thoughts?

@myoung34
Copy link
Author

@tianon this still a thing?

@yosifkit
Copy link
Member

yosifkit commented May 8, 2017

Closing feature requests, since this image is being deprecated.

This image is officially deprecated in favor of the kibana image provided by elastic.co which is available to pull via docker.elastic.co/kibana/kibana:[version] like 5.2.1. This image will receive no further updates after 2017-06-20 (June 20, 2017). Please adjust your usage accordingly.

Elastic provides open-source support for Kibana via the elastic/kibana GitHub repository and the Docker image via the elastic/kibana-docker GitHub repository, as well as community support via its forums.

@yosifkit yosifkit closed this May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants