Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sources.sh to use bashbrew 0.1.10's ArchGitChecksum #16

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

tianon
Copy link
Member

@tianon tianon commented Jan 20, 2024

This makes a very dramatic difference in the speed of sources.sh.

Before:

$ time .scripts/sources.sh $(cat subset.txt) > sources.json
...
real	6m13.444s
user	2m51.334s
sys	3m29.256s

After:

$ time .scripts/sources.sh $(cat subset.txt) > sources.json
...
real	0m31.238s
user	0m32.769s
sys	0m1.375s

@tianon tianon requested a review from yosifkit as a code owner January 20, 2024 00:35
@tianon
Copy link
Member Author

tianon commented Jan 20, 2024

Gahhhhh, I forgot I also needed the sha256sum function 😭

(That's not actually what I would've chosen to name it, but that's what Sprig names it, so in the spirit of avoiding further deviance from them I chose to follow suit.)

@tianon
Copy link
Member Author

tianon commented Jan 20, 2024

@tianon tianon marked this pull request as draft January 20, 2024 00:48
This makes a *very* dramatic difference in the speed of `sources.sh`.

Before:

```console
$ time .scripts/sources.sh $(cat subset.txt) > sources.json
...
real	6m13.444s
user	2m51.334s
sys	3m29.256s
```

After:

```console
$ time .scripts/sources.sh $(cat subset.txt) > sources.json
...
real	0m31.238s
user	0m32.769s
sys	0m1.375s
```
@tianon
Copy link
Member Author

tianon commented Jan 22, 2024

Alright, this should be properly good to go now.

@tianon
Copy link
Member Author

tianon commented Jan 22, 2024

With this it's probably ~safe to revert #9 / #8, but it feels better to take small steps (and that code is definitely working correctly ATM).

@yosifkit yosifkit merged commit ce8c779 into docker-library:main Jan 22, 2024
1 check passed
@yosifkit yosifkit deleted the faster-sources branch January 22, 2024 22:01
@tianon
Copy link
Member Author

tianon commented Jan 22, 2024

The most recent sources.sh-invoking run before this (on the official infrastructure) took ~7m14s; the run after this took ~45s. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants