Duplicated --pidfile during init if passed to mongod at startup

[yoz2326]

I'm passing --pidfilepath=/data/tmp/mongod.pid. When init is finished and mongod is shutdown, this parameter becomes duplicated. So updated the shutdown command to mongod --pidfilepath="$pidfile" --shutdown (line 327)

[yosifkit]

See comments below.

[yosifkit]

This is unnecessary since you can already hook a script to run before the entrypoint by running it before the entrypoint:

COPY my-setup-script.sh /docker-entrypoint-extras.d/my-setup-script.sh
# could also just be CMD if you want to put your mongod args into the file
ENTRYPOINT ["/docker-entrypoint-extras.d/my-setup-script.sh"]
CMD ["docker-entrypoint.sh", "--keyFile", "/path/to/keyfile"]

Contents of my-setup-script.sh:

#!/usr/bin/env bash

# pre-mongod setup 
chmod 400 /path/to/keyfile

# ie: docker-entrypoint.sh --keyFile /path/to/keyfile
exec "$@"

[yoz2326]

Good point, this should do it.
Will drop this change.

[yosifkit]

oh, maybe this should be using "${mongodHackedArgs[@]}" rather than "$@"? cc @tianon

[yoz2326]

In this case I think --pidfile needs to be removed first, if present:

_mongod_hack_ensure_no_arg_val --pidfilepath "${mongodHackedArgs[@]}"
_mongod_hack_ensure_arg_val --pidfilepath "$pidfile" "${mongodHackedArgs[@]}"

and then do:
"${mongodHackedArgs[@]}" --shutdown

[tianon]

The hacked args should already have the pid file path (see the --fork line above), so this line should really be just what you referenced without any new ensures. 👍

[tianon]

(I've force-pushed an update to this for you, and updated all five copies of this file. 👍)

[yoz2326]

Great, thanks for doing this!

[yosifkit]

It looks like both of these would be removed from config for the temp config since they are under security, so this part seems reasonable.

mongo/4.0/docker-entrypoint.sh

Line 156 in f4e1d14

jq 'del(.systemLog, .processManagement, .net, .security)' "$jsonConfigFile" > "$tempConfigFile"

Any value but the default (keyfile) on clusterAuthMode requires sslMode.

Providing a keyFile doesn't stop the user setup or the server from running.

$ docker run -d \
  --name some-mongo \
  -e MONGO_INITDB_ROOT_USERNAME=test \
  -e MONGO_INITDB_ROOT_PASSWORD=12345 \
  --user 1000:1000 \
  -v /home/user/docker/test/mongo/some.key:/some.key \
  -v /home/user/docker/test/mongo/data/:/data/db/ \
  mongo --keyFile /some.key --clusterAuthMode keyFile
$ docker run -it --rm --link some-mongo:mongo mongo mongo --host mongo -u test -p 12345 --authenticationDatabase admin some-db

[yoz2326]

Yes, that's correct. Did this a while back and don't remember exactly what prompted me to remove those agrs.
Will drop this change, thanks for checking it!