Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide jetty image #203

Closed
proppy opened this issue Sep 18, 2014 · 11 comments · Fixed by #469
Closed

Provide jetty image #203

proppy opened this issue Sep 18, 2014 · 11 comments · Fixed by #469

Comments

@proppy
Copy link
Contributor

proppy commented Sep 18, 2014

I'd be nice to have a jetty image based on the _/java one.

It would have to expose tags with different combination of debian/java/jetty version, and default :latest to the sable combinaison (if any) of all 3.

Example:

jetty:8-java6-wheezy
jetty:8-java6-jessie
jetty:9-java7-jessie
jetty:9-java8-experimental

I'm not sure if a :onbuild version would make sense, given that:

  • the build usually happens outside of docker
  • deps are assembled outside of docker by maven and go
  • the entrypoint would be fixed to jetty

/cc @ludoch @ndeloof

@ludoch
Copy link

ludoch commented Sep 19, 2014

/cc @gregw from Jetty.

@md5
Copy link
Contributor

md5 commented Feb 6, 2015

FYI, I took the liberty of starting to work on a Jetty image on the model of the tomcat image this evening. My first pass is here: https://github.com/md5/docker-jetty

@md5
Copy link
Contributor

md5 commented Feb 6, 2015

I also put up an image on the Docker Hub here: https://registry.hub.docker.com/u/mdillon/jetty

The supported tags are: 7-jre7, 7-jre8, 8-jre7, 8-jre8, 9-jre7 (aka latest), and 9-jre8 (per http://download.eclipse.org/jetty/).

@md5
Copy link
Contributor

md5 commented Feb 6, 2015

@tianon
Copy link
Member

tianon commented Feb 6, 2015

url='git://github.com/docker-library/jetty'

echo '# maintainer: InfoSiftr <github@infosiftr.com> (@infosiftr)'
echo '# maintainer: Mike Dillon <mike@embody.org> (@md5)'

If it means we finally get the elusive @md5 to agree to be an official image maintainer, I'm definitely willing to let this one in the list of images we maintain!

I've not dug in deep, but it's looking pretty reasonable so far. 👍

Are you sure you don't want to just keep it for yourself and not even involve us at the image level? 😄

url='git://github.com/md5/docker-jetty'

echo '# maintainer: Mike Dillon <mike@embody.org> (@md5)'

@md5
Copy link
Contributor

md5 commented Feb 6, 2015

I can switch it over to md5/docker-jetty. I was mainly just unclear if there were CLAs or anything involved with Docker, Inc. I suppose I should have a better idea of how this works after watching it for a few months.

@md5
Copy link
Contributor

md5 commented Feb 6, 2015

@md5
Copy link
Contributor

md5 commented Feb 6, 2015

Could you guys answer my implied question about the CLA? Does Docker, Inc need to have an explicit license/copyright on official images or is that just an artifact of @infosiftr's agreement with @docker? I'll update the copyrights from "Docker, Inc" to myself if there is not a requirement to assign to Docker, Inc.

@yosifkit
Copy link
Member

yosifkit commented Feb 7, 2015

@md5, no requirement on copyright to Docker, just expectation of reasonable updates and bug fixes. So yes it is just an artifact of our own agreement with Docker.

Official repos docs; specifically license info

@md5
Copy link
Contributor

md5 commented Feb 7, 2015

I signed up for the jetty-announce list. Assuming I'm not being naive about the type of workload this image will entail, I think I can handle taking care of updates and bug fixes in a timely fashion too.

I'll review those docs and look at creating a PR to pull jetty into the official images.

@yosifkit
Copy link
Member

yosifkit commented Feb 7, 2015

Awesome, thanks @md5. I am sure @tianon will pipe in if I forgot something.

@md5 md5 mentioned this issue Feb 7, 2015
@tianon tianon removed the needsreview label Feb 9, 2015
legolaz8451 pushed a commit to legolaz8451/official-images that referenced this issue Mar 14, 2024
Add AppVeyor for testing Windows builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants