Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Ghost image #505

Merged
merged 1 commit into from Feb 23, 2015
Merged

Add new Ghost image #505

merged 1 commit into from Feb 23, 2015

Conversation

tianon
Copy link
Member

@tianon tianon commented Feb 20, 2015

No description provided.

@tianon
Copy link
Member Author

tianon commented Feb 20, 2015

Build test of #505; 861f58d (ghost):

$ url="https://raw.githubusercontent.com/docker-library/official-images/861f58ddcea4060c8317eac1cf8e4b4734e16789/library/ghost"
$ bashbrew build "$url"
Cloning ghost (git://github.com/docker-library/ghost) ...
Processing ghost:0.5.8 ...
Processing ghost:0.5 ...
Processing ghost:0 ...
Processing ghost:latest ...
$ bashbrew list "$url" | xargs test/run.sh
testing ghost:0.5.8
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing ghost:0.5
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing ghost:0
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing ghost:latest
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed

@md5
Copy link
Contributor

md5 commented Feb 20, 2015

I hate to bring up the fact that it runs as root unnecessarily, but it does :)

@tianon
Copy link
Member Author

tianon commented Feb 20, 2015

You shouldn't hate to bring that up -- keep it coming, because that's an excellent point. 👍

@md5
Copy link
Contributor

md5 commented Feb 20, 2015

It just know that making it run as ghost comes with its own set of complications and limitations.

@md5
Copy link
Contributor

md5 commented Feb 20, 2015

In the case of jetty, I'm leaning toward having it run as jetty by default, documenting the UID and GID, and documenting the hell out of how to change the user for different scenarios. All of which takes time, hence appropriate/docker-jetty#1.

@tianon
Copy link
Member Author

tianon commented Feb 20, 2015

I think we should match the behavior of WordPress here, so I'm updating. 👍

@md5
Copy link
Contributor

md5 commented Feb 20, 2015

So www-data:www-data with id 33?

@tianon
Copy link
Member Author

tianon commented Feb 20, 2015

Well, I mean the general formula. I'm still not 100% sold on www-data with the special 33 ID that may or may not change in later versions of Debian. 🐑

@tianon
Copy link
Member Author

tianon commented Feb 23, 2015

Updated:

Build test of #505; cc325b1 (ghost):

$ url="https://raw.githubusercontent.com/docker-library/official-images/cc325b19ff0ca4fb38abb0294c348248a6cde3cb/library/ghost"
$ bashbrew build "$url"
Cloning ghost (git://github.com/docker-library/ghost) ...
Processing ghost:0.5.8 ...
Processing ghost:0.5 ...
Processing ghost:0 ...
Processing ghost:latest ...
$ bashbrew list "$url" | xargs test/run.sh
testing ghost:0.5.8
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing ghost:0.5
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing ghost:0
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing ghost:latest
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed

@yosifkit
Copy link
Member

LGTM

yosifkit added a commit that referenced this pull request Feb 23, 2015
@yosifkit yosifkit merged commit 37e0e84 into docker-library:master Feb 23, 2015
@yosifkit yosifkit deleted the ghost branch February 23, 2015 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants