Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f21 image: fixed root password #736

Merged
merged 2 commits into from May 15, 2015
Merged

Conversation

vbatts
Copy link
Contributor

@vbatts vbatts commented May 15, 2015

no other changes to the image

/cc @tianon @cgwalters

no other changes to the image
@vbatts
Copy link
Contributor Author

vbatts commented May 15, 2015

fixed the rawhide commit. PTAL.

@cgwalters
Copy link

The rawhide content looks like it correctly fixes the root password.

@tianon
Copy link
Member

tianon commented May 15, 2015

LGTM

Build test of #736; 6464a40 (fedora):

$ url="https://raw.githubusercontent.com/docker-library/official-images/6464a404357c45d47bcd5dfe6657153586294007/library/fedora"
$ bashbrew build "$url"
Fetching fedora (git://github.com/fedora-cloud/docker-brew-fedora) ...
Processing fedora:latest ...
Processing fedora:21 ...
Processing fedora:rawhide ...
Processing fedora:20 ...
Processing fedora:heisenbug ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing fedora:latest
    'utc' [1/3]...failed; unexpected output:
--- /home/tianon/docker/stackbrew/test/tests/utc/expected-std-out.txt   2015-02-05 16:52:05.000000000 -0700
+++ -   2015-05-15 14:28:55.213094261 -0600
@@ -1 +1 @@
-UTC
+EDT
    'cve-2014--shellshock' [2/3]...passed
    'no-root-password' [3/3]...warning: garbage password detected for root: 'locked'
passed
testing fedora:rawhide
    'utc' [1/3]...passed
    'cve-2014--shellshock' [2/3]...passed
    'no-root-password' [3/3]...warning: garbage password detected for root: 'locked'
passed
testing fedora:20
    'utc' [1/3]...passed
    'cve-2014--shellshock' [2/3]...passed
    'no-root-password' [3/3]...warning: garbage password detected for root: 'locked'
passed

@vbatts
Copy link
Contributor Author

vbatts commented May 15, 2015

cool

@yosifkit
Copy link
Member

LGTM

yosifkit added a commit that referenced this pull request May 15, 2015
f21 image: fixed root password
@yosifkit yosifkit merged commit b4cd724 into docker-library:master May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants