Fix conditional "strip" based on "ZEND_DEBUG_BUILD" #1280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit less convinced on this one -- for this new |
|
Yes, you are correct, I am updating the Dockerfile with sed to add |
|
How about using this together with my idea? #1287 |
|
Can this PR be merged? If the template is modified or the DockerFile directly, with this PR, the debug build is detected correctly, and as this align the condition introduced in #1278, I belive such unified check is better than any other condition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strip --strip-allis present on two places, in #1278, it was made conditional for modules, this PR makes it conditional also for the main binaries