Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.3.0 #1464

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Add PHP 8.3.0 #1464

merged 2 commits into from
Nov 27, 2023

Conversation

jnoordsij
Copy link
Contributor

@jnoordsij jnoordsij commented Nov 21, 2023

Modelled after #1353.

Given the 8.3.0 tag is here, the release will follow soon.
This is awaiting the official release to be available on https://www.php.net/releases/index.php?json&max=1&version=8.3, hence the draft state.

Running mkdir 8.3 && ./update.sh and commiting the result should suffice if anyone comes by this when the release is available and I haven't managed yet to update this ;)

@WyriHaximus
Copy link

@jnoordsij It has just been released: https://www.php.net/archive/2023.php#2023-11-23-2

@jnoordsij
Copy link
Contributor Author

jnoordsij commented Nov 23, 2023

Updated to include the new templates!

Note: I have deliberately updated on a commit-by-commit basis, so that if the bot comes by to update the other tags before this gets merged, hopefully git is able to deduce what's happening by spotting duplicate commits and will still be willing to merge this.

Edit: bot got stuck on last build, hence an unexpected error of commits, but I did rebase to resolve conflicts. It seems to be running again (slowly), but it's order of commits should match mine and this should be all set for merge...

@LaurentGoderre
Copy link
Member

@angeljqv the bot updates supported version so this is needed to add 8.3 to the list of supported version.

@damien-louis
Copy link

damien-louis commented Nov 25, 2023

It's time to merge @jnoordsij? ;-p

WyriHaximus added a commit to WyriHaximus/github-action-supported-php-versions that referenced this pull request Nov 25, 2023
@Yurunsoft
Copy link

Looking forward to it!

@xgbnl
Copy link

xgbnl commented Nov 27, 2023

什么时候能拉取8.3的镜像,我的laravel扩展包正准备升级

@ToshY
Copy link

ToshY commented Nov 27, 2023

@LaurentGoderre @yosifkit @tianon Could a maintainer spare some to merge this? Seems people are eagerly waiting for it 🙂

@cedric-anne
Copy link

Or people could simply wait a bit and be patient. I guess none of them have an application specifically designed for PHP 8.3 to push in production inside a docker container just a few days after the PHP 8.3 release date.

Maintainer could spare some time away from their computers, for instance to spend time with their families and/or friends, or to just enjoy some free time.

@jnoordsij
Copy link
Contributor Author

It's time to merge @jnoordsij? ;-p

That'll require a maintainer of the official images. Given that it was Thanksgiving last week, I assume they have a well-deserved long weekend and will be here later today to merge this. After that there will be a few more steps + waiting on the build (see also https://github.com/docker-library/php#see-a-change-merged-here-that-doesnt-show-up-on-docker-hub-yet), so just sit back for a bit and the image will appear at some point.

For those eager to test things: there's always the option to run all your tests on the already available 8.3-rc version, which should behave practically equivalent for almost all purposes, and is probably a good thing to do earlier on if your workflow allows you to test this in preparation for the final release (and as an opportunity to provide feedback before the stable release!).

Finally you can always just take any of the Dockerfiles from this repository or any PR and build them for yourselves if you're not willing to wait for the actual image to show up.

@WyriHaximus
Copy link

It's time to merge @jnoordsij? ;-p

That'll require a maintainer of the official images. Given that it was Thanksgiving last week, I assume they have a well-deserved long weekend and will be here later today to merge this. After that there will be a few more steps + waiting on the build (see also https://github.com/docker-library/php#see-a-change-merged-here-that-doesnt-show-up-on-docker-hub-yet), so just sit back for a bit and the image will appear at some point.

For those eager to test things: there's always the option to run all your tests on the already available 8.3-rc version, which should behave practically equivalent for almost all purposes, and is probably a good thing to do earlier on if your workflow allows you to test this in preparation for the final release (and as an opportunity to provide feedback before the stable release!).

Finally you can always just take any of the Dockerfiles from this repository or any PR and build them for yourselves if you're not willing to wait for the actual image to show up.

This so much this. I've been building my opinionated 8.3 images off the RC images for months so that the transition to stable 8.3 images will be smooth. Honestly, I can wait another week or two since 8.3.0 is effectively a retag of RC6 anyway: php/php-src@d260680...c9e7c2e

@LaurentGoderre @yosifkit @tianon Could a maintainer spare some to merge this? Seems people are eagerly waiting for it 🙂

Yes we are, but we also need to understand at least two of those are in NA. There is a good chance they are finishing off the Thanksgiving weekend or the weekend in general. So give them some time, it's at least taking another 5 to 9 hours before they wake up and maybe look at this today. Just chill :).

@yosifkit yosifkit merged commit df4636c into docker-library:master Nov 27, 2023
58 checks passed
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 27, 2023
Changes:

- docker-library/php@df4636ca: Merge pull request docker-library/php#1464 from jnoordsij/php-8.3
- docker-library/php@f59450af: Add 8.3.0 variant
- docker-library/php@b2ba9199: Update template files for PHP 8.3
- docker-library/php@74548e88: Update 8.2 to 8.2.13
- docker-library/php@671ef331: Update 8.1-rc
- docker-library/php@25e17c7d: Update 8.1 to 8.1.26
- docker-library/php@05882b3e: Update 8.3-rc
- docker-library/php@c3db0de0: Update 8.2-rc
@patrickomeara
Copy link
Contributor

A huge thanks to all maintainers. 🙏🏻

@lol768
Copy link

lol768 commented Nov 27, 2023

Thanks for merging this.

Is it expected to work on an amd64 box?

#2 [linux/amd64 internal] load metadata for docker.io/library/php:8.3-apache
#2 ERROR: no match for platform in manifest: not found

Or is this just down to me being too eager to docker pull it?

@yosifkit
Copy link
Member

docker-library/official-images#15776 (comment)

Short answer: they are still building; only some architectures have finished.

@sbuerk

This comment was marked as off-topic.

@lol768

This comment was marked as off-topic.

@damien-louis

This comment was marked as spam.

mlocati added a commit to mlocati/docker-php-extension-installer that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet