Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compile option --with-mysqli in versions with Apache #7

Merged
merged 2 commits into from Sep 15, 2014

Conversation

mattva01
Copy link
Contributor

Addresses #6

@yosifkit
Copy link
Member

Would it be bad to just drop the --with-mysql, since it is deprecated and mysqli has been available since 5.0?

Other than my question, LGTM.

@mattva01
Copy link
Contributor Author

I thought about that, I think leaving it in is probably the right call since people might want to migrate old codebases into docker. I don't do much php development though (only noticed this when migrating some hackerspace projects into docker), so maybe someone with more PHP experience can chime in?

@tianon
Copy link
Member

tianon commented Sep 12, 2014

I'm +1 on keeping both, especially since the older stuff is still in pretty
wide use.

@yosifkit
Copy link
Member

Then what about PDO?

@mattva01
Copy link
Contributor Author

That's a good point, I didn't add PDO as I wasn't that familiar with it. I'm usually averse to adding a million compile flags, but it probably makes sense as this is supposed to be a base language pack.

@mattva01
Copy link
Contributor Author

I'll add it to this PR if you two think it's the right way to go.

@yosifkit
Copy link
Member

Sounds good to me. @tianon?

@tianon tianon mentioned this pull request Sep 14, 2014
yosifkit added a commit that referenced this pull request Sep 15, 2014
Added compile option --with-mysqli in versions with Apache
@yosifkit yosifkit merged commit 21df8a5 into docker-library:master Sep 15, 2014
@abalage abalage mentioned this pull request Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants