Revert RUBY_MAJOR refactoring for 3.0 #447
Conversation
|
Hmmm, as I look at this, 3.1 is also imminently EOL, so I think my opinion on this is that we should only revert the change for 3.0 and let 3.1 stay as-is (esp. so we can remove the conditional after 3.0 is removed and any downstream breakage from this should be pretty minimal). |
(since it's effectively EOL now except the possibility of a severe regression: https://www.ruby-lang.org/en/news/2024/04/23/ruby-3-0-7-released/)
tianon
force-pushed
the
revert-breaks-security
branch
from
bd69f69
to
1db5a7b
Compare
tianon
changed the title
|
Updated. |
|
@yosifkit is AFK at the moment, but he's ACKed the approach/choices ❤️ |
Changes: - docker-library/ruby@91faf12: Merge pull request docker-library/ruby#447 from infosiftr/revert-breaks-security - docker-library/ruby@1db5a7b: Revert RUBY_MAJOR refactoring for 3.0
| @@ -50,13 +50,13 @@ RUN set -eux; \ | |||
| } >> /usr/local/etc/gemrc | |||
|
|
|||
| ENV LANG C.UTF-8 | |||
| {{ if .version | . == "3.0.6" or . == "3.1.4" or . == "3.2.2" then ( -}} | |||
There was a problem hiding this comment.
@tianon This made our RUBY_MAJOR env var we're relying on in our Dockerfile vanish. We're using this env var for setting the BUNDLE_BIN_PATH (e.g. vendor/bundle/ruby/3.1.0/...). So we were using ruby 3.1.4 and now with 3.1.5, the BUNDLE_BIN_PATH became vendor/bundle/ruby/.0. Sure, I can workaround this, but the change seems wrong and it might affect others!
There was a problem hiding this comment.
the implementation is a bit weird anyway, we thought RUBY_MAJOR (that is 3.0, 3.1, 3.2. 3.3 ...) has some kind of significance in any RUBY_VERSION (e.g. 3.1.4 or 3.1.5)
There was a problem hiding this comment.
Sorry for the breakage, but it is a variable we never intended to expose (and with a name that isn't really accurate for what it is).
There was a problem hiding this comment.
didn't know and who else might not know it. we're deploying a fix right now. thanks
|
Sorry for being a bit harsh earlier on, I was just surprised how the pull of the |
(since it's effectively EOL now except the possibility of a severe regression: https://www.ruby-lang.org/en/news/2024/04/23/ruby-3-0-7-released/)
See #435