Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL documentation contains a small bug #2381

Closed
Twist235 opened this issue Jan 26, 2022 · 1 comment · Fixed by #2383
Closed

SSL documentation contains a small bug #2381

Twist235 opened this issue Jan 26, 2022 · 1 comment · Fixed by #2383

Comments

@Twist235
Copy link
Contributor

Subject

I would like to contribute to the project

Description

I propose to perform a documentation update:

Section:
Let's Encrypt (Recommended)
Subsection:
Example

Add these additions to the mailserver service in your docker-compose.yml:

services:
mailserver:
# For the FQDN 'mail.example.com':
hostname: mail
domainname: example.com
environment:
- SSL_TYPE=letsencrypt
volumes:
- /etc/letsencrypt:/etc/letsencrypt

Change bold part to
- ./docker-data/certbot/certs/:/etc/letsencrypt

Description of problem:
In this example, a different path is used than in the following Example "using Docker for Let's Encrypt". I propose to use the same path both times. This cost me some time to find, when I follow the examples the docker restarts and I did not understand why.

I would be happy to update it myself (and maybe add some sentences for DNS cert which I used) but I do not have the rights (new to github).

@Twist235 Twist235 added kind/question Someone asked a question - feel free to answer meta/help wanted The OP requests help from others - chime in! :D meta/needs triage This issue / PR needs checks and verification from maintainers priority/low labels Jan 26, 2022
@georglauterbach
Copy link
Member

Thank you for reporting this.

I would be happy to update it myself (and maybe add some sentences for DNS cert which I used) but I do not have the rights (new to github).

Please just have a look at our documentation on how to contribute to this project. Quick read and you should be able to open a PR (pull request) which we can then review and merge if appropriate.

@georglauterbach georglauterbach added area/documentation kind/bug priority/medium and removed meta/needs triage This issue / PR needs checks and verification from maintainers meta/help wanted The OP requests help from others - chime in! :D kind/question Someone asked a question - feel free to answer priority/low labels Jan 26, 2022
@georglauterbach georglauterbach added this to the v10.5.0 milestone Jan 26, 2022
Twist235 added a commit to Twist235/docker-mailserver that referenced this issue Jan 26, 2022
Update of example to be more consistent with the next one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants