Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify Configuration #815

Closed
17Halbe opened this issue Feb 5, 2018 · 1 comment · Fixed by #822
Closed

simplify Configuration #815

17Halbe opened this issue Feb 5, 2018 · 1 comment · Fixed by #822
Assignees

Comments

@17Halbe
Copy link
Contributor

17Halbe commented Feb 5, 2018

What about moving all configuration options into an .env file?
This is the docker-compose way of configuring environmental variables anyway. See env-file

Benefits would be:

  • The user wouldn't have to mess around in the compose file itself which we in turn wouldn't have to debug. 👍
  • It's backward compatible: If one uses his old docker-compose file nothing would change.
  • We could explain each variable in the config (.env) file itself.

Sounds cool?

@johansmitsnl
Copy link
Contributor

Users can use both at the same time. It could definitely be mentioned in the readme page with a example to.

@17Halbe 17Halbe mentioned this issue Feb 7, 2018
Merged
johansmitsnl pushed a commit that referenced this issue Feb 7, 2018
Introduce .env for docker-compose examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants