Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostname/domainname override tests don't actually test anything #939

Closed
crazystick opened this issue Apr 5, 2018 · 3 comments
Closed

hostname/domainname override tests don't actually test anything #939

crazystick opened this issue Apr 5, 2018 · 3 comments

Comments

@crazystick
Copy link
Contributor

The actual hostname and the override hostname for the container mail_override_hostname are equal, so all those tests are going to pass whether or not the hostname override feature works!
crazystick added a commit to crazystick/docker-mailserver that referenced this issue Apr 5, 2018
@crazystick
set postmaster address to a sensible default, closes docker-mailserve…
534c666 
…r#938, closes docker-mailserver#939
@johansmitsnl
Copy link
Contributor

Could you provide a PR for changing the tests?

@crazystick
Copy link
Contributor Author

You want me to separate PR #940 into two separate ones?

johansmitsnl pushed a commit that referenced this issue Apr 5, 2018
@crazystick @johansmitsnl
set postmaster address to a sensible default (#938, #939, #940)
a564cca
@johansmitsnl
Copy link
Contributor

No not needed, just did not see your PR yet. It just got merged, thnx for the contribution!

johansmitsnl added a commit that referenced this issue Apr 23, 2018
@johansmitsnl
Merge tag 'v6.0.0'
39954da 
Release 6.0.0

* Implementation of multi-domain relay hosts (#922, #926)
  AWS_SES_HOST and AWS_SES_PORT are deprecated now.
  RELAY_HOST and RELAY_PORT are introduced to replace them.
* Password creation fix (#908, #914)
* Fixes 'duplicate log entry for /var/log/mail/mail.log' (#925, #927)
* fixed cleanup (mail_with_relays didn't get cleaned up) (#930)
* fix line breaks in postfix-summary mail error case (#936)
* Set default virus delete time (#932, #935)
  This defaults to 7 days
* Ensure that the account contains a @ (#923, #924)
* Introducing global filters. (#934)
* add missing env vars to docker-compose.yml (#937)
* set postmaster address to a sensible default (#938, #939,  #940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crazystick @johansmitsnl