Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set Nameservers in opendkim.conf at start-up #1205

Merged
merged 2 commits into from
Aug 4, 2019
Merged

set Nameservers in opendkim.conf at start-up #1205

merged 2 commits into from
Aug 4, 2019

Conversation

j-marz
Copy link
Contributor

@j-marz j-marz commented Aug 3, 2019

Fix for #1204

@erik-wramner
Copy link
Contributor

Looks good. Have you tried it with a real server?

It would also be nice with a test, see test/tests.bats. You could assert that the config file contains the expected line(s).

@j-marz
Copy link
Contributor Author

j-marz commented Aug 3, 2019

Looks good. Have you tried it with a real server?

Yes, running on my server.

It would also be nice with a test, see test/tests.bats. You could assert that the config file contains the expected line(s).

I'll try do this tomorrow.

@j-marz
Copy link
Contributor Author

j-marz commented Aug 4, 2019

@erik-wramner test added and confirms 8a1584c is working.

@erik-wramner erik-wramner merged commit 41921f8 into docker-mailserver:master Aug 4, 2019
@aminvakil aminvakil mentioned this pull request May 18, 2020
Closed
@polarathene polarathene mentioned this pull request Feb 5, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j-marz @erik-wramner