add dovecot-fts-xapian #2064
Merged
add dovecot-fts-xapian #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update Docker to build from debian bullseye slim, as it contains packages for fts-xapian. update Docker to install dovecot-fts-xapian. update docs with instructions on how to enable fts-xapian or fts-solr and what considerations to take into when deciding.
wernerfred
reviewed
Jul 3, 2021
|
Until Debian 11 is officially released, we should stick with the current version. The backport repo addition can then easily be removed once v11 is out. |
casperklein
reviewed
Jul 3, 2021
|
It seems, that our tests doesn't like bullseye yet 😋 |
casperklein
reviewed
Jul 3, 2021
casperklein
reviewed
Jul 3, 2021
casperklein
reviewed
Jul 3, 2021
eleith
force-pushed
the
dovecot-fts-xapian
branch
from
5b462a2
to
dafc046
Compare
eleith
force-pushed
the
dovecot-fts-xapian
branch
from
dafc046
to
d56f1e5
Compare
|
addressed documentation feedback and used buster/backports approach instead. thanks everyone. |
casperklein
reviewed
Jul 3, 2021
…t in a forced push)
eleith
force-pushed
the
dovecot-fts-xapian
branch
from
e2d119c
to
2786cd2
Compare
|
"restored" proposal for backports from 5b462a2 |
casperklein
approved these changes
Jul 3, 2021
wernerfred
approved these changes
Jul 5, 2021
wernerfred
added
area/documentation
area/features
kind/new feature
|
@eleith Great first contribution, thank you. |
|
Documentation preview for this PR is ready! 🎉 Built with commit: b1c16d5 |
|
Why tf did the merge went through with one test action still running. Need to investiagate 👀 |
|
@all-contributors please add @eleith for infrastructure |
|
I've put up a pull request to add @eleith! 🎉 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR updates Docker to install dovecot-fts-xapian.
unfortunately, that package is only available on
buster-backportsso either Docker needs to be updated to pull from backports or the build can usebullseye-slimas the base image (which is nearing stable release in July 2021).currently, this PR introduces
bullseye-slimwhich is a rather large change.I imagine this project will eventually adopt bullseye given its long testing cycle and relative stability. If so, this PR can be merged with that branch.
With that said, I would be happy to use
buster-backportsas well and i have a working branch, if desired. That approach merely requires updating Docker to add to apt a new source pointing to buster backports before installing dovecot and other software.Lastly, this PR also updates relevant docs with instructions on how to enable fts-xapian
and what considerations to take into when deciding to turn on FTS and choose between xapian and solr.
Fixes #2061
Type of change
Checklist:
docs/)