Move setup process via script into container #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georglauterbach
added
pr/needs review
priority/medium
area/scripts
kind/improvement
|
MkDocs does not seem to render ~~ (crossed out) correctly. @wernerfred @polarathene do you have any idea how to fix this? I mean, it's just a joke in the docs and we can remove it, but it makes me curious. |
polarathene
reviewed
Sep 7, 2021
polarathene
reviewed
Sep 7, 2021
polarathene
requested changes
Sep 7, 2021
Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
polarathene
previously approved these changes
Sep 9, 2021
8 tasks
|
@docker-mailserver/maintainers Tests should pass again (rebased on |
casperklein
requested changes
Sep 11, 2021
There was a problem hiding this comment.
See my suggestions to remove MacOS specific quirks, intruduced in #2001
Co-authored-by: Casper <casperklein@users.noreply.github.com>
Co-authored-by: Casper <casperklein@users.noreply.github.com>
Co-authored-by: Casper <casperklein@users.noreply.github.com>
Co-authored-by: Casper <casperklein@users.noreply.github.com>
Co-authored-by: Casper <casperklein@users.noreply.github.com>
Co-authored-by: Casper <casperklein@users.noreply.github.com>
Co-authored-by: Casper <casperklein@users.noreply.github.com>
|
Documentation preview for this PR is ready! 🎉 Built with commit: 512de25 |
NorseGaud
reviewed
Sep 11, 2021
casperklein
approved these changes
Sep 11, 2021
polarathene
approved these changes
Sep 11, 2021
casperklein
reviewed
Sep 15, 2021
NorseGaud
pushed a commit
to NorseGaud/docker-mailserver
that referenced
this pull request
Sep 17, 2021
Decoupling setup process from `setup.sh` script by introducing a setup script _inside_ the container that coordinates the setup process. **This is not a breaking change**. This way, we do not have to keep track of versions of `setup.sh`. This change brings the additional benefit for Kubernetes users to be able to make use of `setup` now, without the need for `setup.sh`. --- * move setup process into container; setup.sh versioning not needed anymore * add tilde functionality to docs Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com> Co-authored-by: Casper <casperklein@users.noreply.github.com>
NorseGaud
pushed a commit
to NorseGaud/docker-mailserver
that referenced
this pull request
Sep 17, 2021
Decoupling setup process from `setup.sh` script by introducing a setup script _inside_ the container that coordinates the setup process. **This is not a breaking change**. This way, we do not have to keep track of versions of `setup.sh`. This change brings the additional benefit for Kubernetes users to be able to make use of `setup` now, without the need for `setup.sh`. --- * move setup process into container; setup.sh versioning not needed anymore * add tilde functionality to docs Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com> Co-authored-by: Casper <casperklein@users.noreply.github.com>
|
I have updated the blog post to cover the new conditions regarding setup. I'd also like to take the opportunity to thank you for your efforts! |
You're welcome! :) You blog post was the reason I actually started this as it was very valid and hard (but correct, which I appreciate) criticism. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decoupling setup process from
setup.shscript by introducing a setup script inside the container that coordinates the setup process. This is not a breaking change. This way, we do not have to keep track of versions ofsetup.sh, which was said to be a no-no here. This is a blog post we're linking to in our documentation. This change brings the additional benefit for Kubernets users to be able to make use ofsetupnow, without the need forsetup.sh.The maintainers discussion referencing / talking about the current
setup.shversioning-problem can be found here.This PR was really made possible by @NorseGaud with #2134
Type of change
Checklist:
docs/)