chore: Refactor setup-stack.sh case SSL_TYPE=letsencrypt
#2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't attempt to extract for `SSL_DOMAIN` if the value is empty. - Added `EXTRACTED_DOMAIN` and error + debug log output for better troubleshooting.
- Removed some unnecessary nesting. - Correct handling for `SSL_DOMAIN`. - Less repetitive error message for `LETSENCRYPT_DOMAIN`. - Added use of panics where appropriate (kept `return 1` so failures still exit functionality early).
Correct the indentation mistake spotted by CI lint job.
georglauterbach
added
area/scripts
kind/improvement
|
Please label your PRs to make it more obvious what they are about even when not having them opened :) |
casperklein
requested changes
Nov 1, 2021
Co-authored-by: Casper <casperklein@users.noreply.github.com>
Oh sure! Sorry I never thought about that 😅 |
georglauterbach
approved these changes
Nov 2, 2021
casperklein
approved these changes
Nov 2, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This has been extracted from #2245 as it does not need to be part of that PR.
To function correctly, it depends on a
helper-function.shmethod added in #2274 , tests will pass once that is merged.Mostly cleans up the code and documents it better, although there are some minor fixes for handling
SSL_DOMAINENV and additional logging added for spotting issues related to it in future when troubleshooting.Commits are scoped with context messages for easing review if necessary. Overview of changes:
Traefik specific:
SSL_DOMAINmust not be empty when attempting to extract.SSL_TYPE=letsencryptcase:SSL_DOMAIN.LETSENCRYPT_DOMAIN.return 1so failures still exit functionality early).Type of change
Checklist: