Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchmailrc split: ignore commented lines #2305

Conversation

gutmensch
Copy link
Contributor

@gutmensch gutmensch commented Nov 27, 2021

* currently a commented line with "poll" in it is not ignored
  although [fetchmail source](https://gitlab.com/fetchmail/fetchmail/-/blob/legacy_64/rcfile_l.l#L218) defines
  hash as valid comment character

* this can cause the script to setup a broken service file, which
  results in supervisor indefinite restart loops and high cpu usage

* suggestion: delete all commented lines before parsing

Description

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@gutmensch gutmensch force-pushed the fetchmailsplit-fix-commented-lines branch from 44e9a57 to 27ba254 Compare November 27, 2021 17:54
	* currently a commented line with "poll" in it is not ignored
	  although https://gitlab.com/fetchmail/fetchmail/-/blob/legacy_64/rcfile_l.l#L218
	  hash as valid comment character

	* this can cause the script to setup a broken service file, which
	  results in supervisor indefinite restart loops and high cpu usage

	* suggestion: delete all commented lines before parsing
@gutmensch gutmensch force-pushed the fetchmailsplit-fix-commented-lines branch from 27ba254 to 7d1d8a8 Compare November 27, 2021 17:58
@georglauterbach georglauterbach added area/scripts area/security kind/improvement Improve an existing feature, configuration file or the documentation priority/medium meta/feature freeze On hold due to upcoming release process labels Nov 27, 2021
@georglauterbach georglauterbach requested a review from a team November 27, 2021 18:16
@georglauterbach
Copy link
Member

This PR will be merged after #2299 is merged.

Approximately tomorrow (29th) or the day(s) after.

@georglauterbach georglauterbach removed the meta/feature freeze On hold due to upcoming release process label Nov 29, 2021
@georglauterbach georglauterbach merged commit b11e5ff into docker-mailserver:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scripts kind/improvement Improve an existing feature, configuration file or the documentation priority/medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants