New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(deps): bump mkdocs-material to new major version 8 #2311
Conversation
I believe we already handled As for checking if a preview broke in an automated way, there are some tools/services for webpage diffs, they might be useful or sometimes just noise. We may qualify for the free or open-source tiers of some services that we could integrate the CI with, at least for PRs that bump the mkdocs container version.. I don't have spare time to allocate to such unfortunately.
That would be good too. I'm hoping to have some time to push my contributors doc page that was left WIP early in the year, that covered a bunch of features with examples to show how we could leverage them in our docs. Probably been some additions since that need to be added too 😅 I should be able to get that sorted out later this month or early Jan. |
@polarathene can you have a look at https://squidfunk.github.io/mkdocs-material/setup/setting-up-versioning/#version-warning I'm not sure if i implemented this correctly in 9d35f1e by setting the version to EDIT: Seems like i broke it anyways with 1d44ad9 |
I'd not add the version warning. We actually encourage users to pick the right version they're running, not just using PS: Will share some more feedback later. Going to sleep now. |
I'd add |
We can introduce new annotation with new PRs in the future. I'd advise against overhauling all code blocks with this feature in this PR - this PR should just introduce the feature.
I added the code annotation syntax. I'm fine with this PR then :D |
Isn't that the purpose of this feature too? You may end up on the docs via link from a blog / guide about I know that I've wound up on docs for certain projects via links that turned out to be the older releases, docs for rust crates / packages for example. If you'd like to have it, but have trouble getting it working, for now perhaps just comment out the feature with a note about enabling it later (or separate PR/issue) if you don't want to block updating the image version 😅 I'd look into it myself but backlog is a bit busy elsewhere currently.
docker-mailserver/versions.json Lines 2 to 6 in 2f14e13
Should be fine to add the {
"version": "edge",
"title": "edge",
- "aliases": []
+ "aliases": [ "latest" ]
}, Or adjust the |
I'd still not add it. I think MkDocs makes a very good job at showing the version selector at the very top:) @wernerfred If you think this PR is ready, just request me for review. |
re-add if version warning gets a thing in the future. See #2311 (comment)
Documentation preview for this PR is ready! 🎉 Built with commit: 36aefb7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed my changes were overridden? Was there a reason for this? Either way, I'm very much fine with this :)
Maybe a caching issue? I only have one commit from your side (ignoring the master merges) and this one is still in place: |
You're right: May GitHub app on my smartphone did cache to aggressively. Very good, all is well! |
Description
bump mkdocs-material to 8.0.2
Todos:
Main changes:
Type of change
Checklist:
docs/
)