scripts: streamline 'printf' usage and consequently use a format string

[casperklein]

Description

This PR streamlines the printf usage and consequently uses a format string. This (best) practice also avoids possible problems with strings containing special characters like %s, \n etc.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (non-breaking change that does improve existing functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (README.md or the documentation under docs/)
• If necessary I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[casperklein]

Converting this

printf "\e[35mADDALIAS\e[31m(\e[93m8\e[31m)

to

printf '%s' "\e[35mADDALIAS\e[31m(\e[93m8\e[31m)

does not work. \e[35m will not be evaluated as the color purple.

All scripts already source helpers/index.sh. I think it's the best, to centrally define all colors and then just use them as vars.
There is already something like this here:

docker-mailserver/target/scripts/helpers/log.sh

Lines 3 to 8 in 49a337c

	LOG_RESET='\e[0m'
	LOG_LGRAY='\e[37m'
	LOG_LBLUE='\e[94m'
	LOG_BLUE='\e[34m'
	LOG_LYELLOW='\e[93m'
	LOG_RED='\e[91m'

But not all colors are covered there + variable names refer to log stuff.

I propose to:

1. add missing colors
2. change variable names to something more general like $RED or $COLOR_RED instead of $LOG_RED.
3. and use these variables in other scripts.

If there is consensus, I'll take care of this in a separate PR and adjust this PR afterwards.

[georglauterbach]

I propose to:

1. add missing colors
2. change variable names to something more general like $RED or $COLOR_RED instead of $LOG_RED.
3. and use these variables in other scripts.

If there is consensus, I'll take care of this in a separate PR and adjust this PR afterwards.

Sounds very good to me - I’m all for it 👍🏼