Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: run sedfile tests in container #2569

Merged
merged 6 commits into from
May 5, 2022
Merged

tests: run sedfile tests in container #2569

merged 6 commits into from
May 5, 2022

Conversation

casperklein
Copy link
Member

@casperklein casperklein commented Apr 29, 2022 •
edited

Description

This PR adjusts the sedfile tests to run inside a container. This allows the removal of the workaround inside sedfile.

Fixes: #2507 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein added area/tests kind/improvement Improve an existing feature, configuration file or the documentation labels Apr 29, 2022
@casperklein casperklein added this to the v11.1.0 milestone Apr 29, 2022
@casperklein casperklein self-assigned this Apr 29, 2022
@casperklein casperklein requested a review from a team April 29, 2022 23:39
@casperklein casperklein marked this pull request as ready for review April 29, 2022 23:39
@casperklein casperklein merged commit 18acd78 into docker-mailserver:master May 5, 2022
@casperklein casperklein deleted the sedfile-test branch May 5, 2022 10:58
@georglauterbach georglauterbach changed the title Run sedfile tests in container tests: run sedfile tests in container May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels
area/tests kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Milestone
v11.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@casperklein @polarathene @georglauterbach