tests: Extract setup.sh cases to their own test file
#2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bare minimum to setup a new test.
Only applied where it's relevant. Next commit will handle the config path correction.
Could technically use the existing function call. Some paths were using a hard-coded config location. Both have been converted to `TEST_TMP_CONFIG` and related `grep` calls normalizing the quote mark usage, escaping doesn't seem necessary.
polarathene
added
area/ci
area/tests
kind/improvement
5 tasks
If a variable name (of an array) was not provided to reference, this would fail trying to reference `'`.
georglauterbach
approved these changes
Jun 7, 2022
casperklein
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of a race condition observed here that would reliably trigger on CI, but not a local VM; these tests were impacting unrelated subsequent tests for
supervisorddue to change detection service now being activated as part of that PR. (EDIT: Additional test runs failed other tests inbetween these two as well that relied on Postfix not being down temporarily)To avoid that issue, the tests have been extracted into their own one.
Staged out into several commits (with commit messages for additional context) for ease of review diff viewing..
Type of change
Checklist: