Streamline COPY statements in Dockerfile

[casperklein]

Description

Nothing big.. Just streamlining the COPY usage In Dockerfile. Some statements used ./, while some did not.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (non-breaking change that does improve existing functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (README.md or the documentation under docs/)
• If necessary I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[georglauterbach]

@polarathene I'm a bit afraid that #2729 shows that there still are timing-related problems with our tests, but test failures are now happening in PRs for which tests should run fine. Anything we can do here as a follow-up?

[georglauterbach]

See #2752 (comment).

[polarathene]

but test failures are now happening in PRs for which tests should run fine. Anything we can do here as a follow-up?

Can you link to the PR with failing test?

I saw this one, but not sure if this was due to the issues you fixed in later commits? (due to a package you had omitted from the build)

---

Early setup of test/tests.bats is the area that's been mostly sensitive to timing.

There's also a check-for-changes.sh test for remove_lock() which failed one time likely due to timing issues, but the method didn't output anything to log when the conditions were not met IIRC. If it happens again, I'd patch it, otherwise when I have time later in the year I would like to tackle switching back to flock().

[casperklein]

See #2752 (comment).

Overlooked that. I thought the comment was about the failing tests 😟

[georglauterbach]

See #2752 (comment).

Overlooked that. I thought the comment was about the failing tests worried

No worries. Due to the large feedback, I will provide separate PRs and close #2752 :)